WSTEAMA-1429 Add languages link to footer for all services #12136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoore108
approved these changes
Nov 5, 2024
karinathomasbbc
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA [1429]
Overall changes
Added this
to the array of link objects in each of the services' config files, after the last one I see present on the current footer.
Code changes
Testing
To test locally, check out this branch and visit a page from each service. Check that the 'Other Languages' link is there in the last position in that links section (before copyright at the bottom), and links to https://www.bbc.com/ws/languages.
Do an a11y check on LTR and RTL that the links are announced correctly by screenreaders as a link that is the last in the list.
Same testing for test and live environments.
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines