-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAMA-1515-added support for routes to have variants at the end #12333
Merged
Nabeel1276
merged 11 commits into
latest
from
WSTEAMA-1514-update-topics-urls-to-include-script-at-the-end
Jan 27, 2025
Merged
WSTEAMA-1515-added support for routes to have variants at the end #12333
Nabeel1276
merged 11 commits into
latest
from
WSTEAMA-1514-update-topics-urls-to-include-script-at-the-end
Jan 27, 2025
+262
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apologies for having this all in one commit, I made the changes on latest and then transferred them to a new branch and was having issues with git. |
…-script-at-the-end
…e-end' of github.com:bbc/simorgh into WSTEAMA-1514-update-topics-urls-to-include-script-at-the-end
amoore108
reviewed
Jan 24, 2025
amoore108
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
karinathomasbbc
approved these changes
Jan 27, 2025
Nabeel1276
deleted the
WSTEAMA-1514-update-topics-urls-to-include-script-at-the-end
branch
January 27, 2025 12:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves (https://jira.dev.bbc.co.uk/browse/WSTEAMA-1514)
Overall changes
Added support for routes with variants such that the variant is at the end of the script. e.g.
Before: /service/variant/topics/id
After: /service/topics/id/variant
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines