Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better loading & ✨hooks ✨ #1335

Closed
wants to merge 6 commits into from
Closed

Better loading & ✨hooks ✨ #1335

wants to merge 6 commits into from

Conversation

dr3
Copy link

@dr3 dr3 commented Feb 21, 2019

Resolves #1302

Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval
  • I have followed the merging checklist and this is ready to merge.

@jamesbhobbs
Copy link
Contributor

@dr3 can you update this PR description please? I'm unclear if this is to be scrapped or finished?

@dr3
Copy link
Author

dr3 commented Apr 1, 2019

Closing as out of date

@dr3 dr3 closed this Apr 1, 2019
@dr3 dr3 deleted the BetterLoading branch April 1, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr3 @jamesbhobbs