Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook Rewrite - Components #9208

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Storybook Rewrite - Components #9208

merged 3 commits into from
Jul 13, 2021

Conversation

ryanmccombe
Copy link
Contributor

@ryanmccombe ryanmccombe commented Jun 29, 2021

Part of #9198

Overall change:
A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.

  • I have assigned myself to this PR and the corresponding issues
  • I have added the cross-team label to this PR if it requires visibility across World Service teams
  • I have assigned this PR to the Simorgh project
  • (BBC contributors only) This PR follows the repository use guidelines

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
  • This PR requires manual testing

@ryanmccombe ryanmccombe changed the title Storybook examples Storybook - CSF Rewrite Jul 7, 2021
@ryanmccombe ryanmccombe changed the base branch from storybook-upgrade to latest July 7, 2021 10:46
@ryanmccombe ryanmccombe self-assigned this Jul 7, 2021
@ryanmccombe ryanmccombe changed the title Storybook - CSF Rewrite Storybook Rewrite - Components Jul 11, 2021
@ryanmccombe ryanmccombe marked this pull request as ready for review July 12, 2021 09:01
@ryanmccombe ryanmccombe merged commit e603f66 into latest Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants