fix: ab playback resolver not allowing sessions to span between segments SUPERFLY-5 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterC89
approved these changes
Apr 9, 2024
Julusian
changed the base branch from
release51
to
upstream/SUPERFLY-5-ab-sessions-across-parts
Julusian
changed the base branch from
upstream/SUPERFLY-5-ab-sessions-across-parts
to
upstream-release51
|
Upstream: nrkno#1261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in SUPERFLY-5, AB sessions should persist across parts, and it should be possible to do so across segments.
In the code it was doing
Check if we can continue sessions from the part before, or if we should create new ones, but the check was only looking at the rank of the parts, which is really the rank inside the segment.This expands that check to correctly consider the rank of the owning segment when they are in different segments and consider the rank of the parts only when they are in the same segment.
This has been verified with the addition of a new unit test, no manual testing has been performed currently.