Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producer.send message input type added #54

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Conversation

qvantor
Copy link
Contributor

@qvantor qvantor commented Jul 3, 2020

Description

Added message type support in .send method

Motivation and Context

#51

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • My change DONT requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@qvantor
Copy link
Contributor Author

qvantor commented Jul 6, 2020

@jeanrauwers @nspragg @koresar Could you review changes, please?

@koresar
Copy link
Contributor

koresar commented Jul 6, 2020

Looks perfect to me. But I'm not a maintainer mate. I'm like you - an inpatient contributor. 😀

@jeanrauwers jeanrauwers self-assigned this Jul 6, 2020
@jeanrauwers
Copy link
Contributor

Sorry guys we are having to do lots into our inner source as well!
but thanks for your PR it looks fine to me! 👍

@jeanrauwers jeanrauwers merged commit 1016aae into bbc:master Jul 6, 2020
@vorticalbox
Copy link

when will this be released to npm?

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants