Add config option to set threads for saving images #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing i've found that using around 1.5 times the CPU cores available on a machine yields the best performance with saving images. This is really important on machines with a lot of cores, we use 32 core machines in our tests and using up all the cores cuts down wraith time in half. 8 seems like a good default, this PR adds the ability to change the value.
|
👍 |
|
I have been using this on my local branch and it has added a tremendous amount of flexibility in testing. I am currently favoring closer to 2x the # cores, but 1.5 is good as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing i've found that using around 1.5 times the CPU cores
available on a machine yields the best performance with saving images.
This is really important on machines with a lot of cores, we use 32 core
machines in our tests and using up all the cores cuts down wraith time
in half.
8 seems like a good default, this PR adds the ability to change the
value.