IL2CPP - Shim UnityEngine.Input to fix failing to find the type in some games #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yEngine.InputLegacyModule
ManlyMarco
reviewed
Jun 19, 2024
ManlyMarco
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Confirmed to be working. This is only going to affect IL2CPP so there won't be any effect on old mono versions.
This is a pretty dirty solution, but it is very simple and self-contained so I think it's fine to merge as is.
Ideally there would be a full abstraction class that also handles Unity.InputSystem like BepInEx.UnityInput, but that can be copied from BepInEx later whenever it's ported to the master branch (and it would require some refactoring all over the place).
ManlyMarco
changed the title
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I use relection to resolve UnityEngine.Input in both UnityEngine.CoreModule and UnityEngine.InputLegacyModule.
I don't have enviroment to test in old version Unity. No sure it is compatable or not.