Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the outline style lost when overriding TextMeshPro Font #494

Merged
merged 3 commits into from
Sep 5, 2024
Merged

fix the outline style lost when overriding TextMeshPro Font #494

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e4037b
fix the outline style lost when overriding TextMeshPro Font
ekibun Feb 14, 2024
e71fae2
fix crash in il2cpp when override font
ekibun Feb 14, 2024
b1ec37f
Refactor
ManlyMarco Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/XUnity.AutoTranslator.Plugin.Core/TextTranslationInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using XUnity.Common.Constants;
using XUnity.Common.Extensions;
using XUnity.Common.Harmony;
using XUnity.Common.Logging;
using XUnity.Common.Utilities;

namespace XUnity.AutoTranslator.Plugin.Core
Expand Down Expand Up @@ -132,14 +133,47 @@ public void ChangeFont( object ui )

if( !UnityObjectReferenceComparer.Default.Equals( newFont, previousFont ) )
{
var fontMaterialProperty = clrType.CachedProperty( "fontSharedMaterial" );
var oldMaterial = fontMaterialProperty.Get( ui );

fontProperty.Set( ui, newFont );

var newMaterial = fontMaterialProperty.Get( ui );

if( oldMaterial != null && newMaterial != null )
{
object copyMaterial = null;
if( !_matCopies.TryGetValue( oldMaterial, out copyMaterial ) )
{
copyMaterial = _matCopies[ oldMaterial ] = UnityEngine.Object.Instantiate( oldMaterial as Material );

// keep original font
var uiCopy = UnityEngine.Object.Instantiate( ui as UnityEngine.Object );
ManlyMarco marked this conversation as resolved.
Show resolved Hide resolved
fontProperty.Set( uiCopy, previousFont );
fontMaterialProperty.Set( uiCopy, oldMaterial );

copyMaterialProperties( copyMaterial as Material, newMaterial as Material );
}
fontMaterialProperty.Set( ui, copyMaterial );
}

_unfont = obj =>
{
fontProperty.Set( obj, previousFont );
fontMaterialProperty.Set( obj, oldMaterial );
};
}
}
}
static WeakDictionary<object, object> _matCopies = new WeakDictionary<object, object>();

static void copyMaterialProperties( Material dst, Material src )
{
dst.SetTexture( "_MainTex", src.GetTexture( "_MainTex" ) );
dst.SetFloat( "_TextureHeight", src.GetFloat( "_TextureHeight" ) );
dst.SetFloat( "_TextureWidth", src.GetFloat( "_TextureWidth" ) );
dst.SetFloat( "_GradientScale", src.GetFloat( "_GradientScale" ) );
}

public void UnchangeFont( object ui )
{
Expand Down