Issues with the new task bar grouping

[exebook]

First, thank you very much for enabling this, it is super cool!

Grouping works as expected, it groups firefox, xterm, thunar, putty, chromium, vscode, mpv, inkscape, kitty, terminator. That's all I tried.

Here are some minor issues I found so far:

Icon badge counter looks weird, overlapping text:

I do not have a great solution for that, but here is for example what Firefox does for badge coutners:

Shutter's idea of adding [1] to the title is also lovely:

Other issue is that my task bar is at the top of the screen and drop down menu aligns to the top of the taskbar even though it should be at the bottom for me:

Also menu behaves inconsistently with the "Start" menu, i.e. for the start menu I do:
-mouse down
-mouse up
-move mouse to select an item
-mouse down
-mouse up

But for the task group menu I do:
-mouse down
-move the mouse to select an item
-mouse up

I prefer the first way (like in windows 95) so maybe I have this option in the preferences file, do not remember, if there is such option it should probably be consistent for both types of menu, the start and the group selection, if there is no such option, then they just should be the same probably, just thinking. Probably no reason to have two settings, because users probably want all menus working the same way.

[exebook]

Another one: moving task bar items left and right with Control down does not work for the grouped items, although it works for others.

[gijsbers]

Your feedback was incorporated. Please try again.

[exebook]

It is almost perfect now. Although the badge counter still seems a bit off for me. And it's padding is nearly zero btw.

One problem though is that when I tried to move the taskbar to the bottom with ALT+drag the menu was popping aligned wrongly to the bottom. I thought maybe that's because I moved it with ALT and not with the preferences setting, so I reached to the Start menu where I have a link to Geany to open Preferences, but it did not work. So start menu opens but selecting items does nothing, all menu items are in place but do not work. I had to git checkout HEAD~ and recompile to get the menu back.

[danfe]

Thanks, this is a nice feature indeed. However, I'm a bit surprised that when I enable it, it groups all windows across all worskspaces, not just those which belong to the current one. Is there a way to control this?

Second, the window counter looks a bit ugly sometimes, e.g. look at the attached screenshot. Would it be possible to move it all the way to the right or somehow otherwise avoid interference (overlap) with the icon and title?

[gijsbers]

Maybe this the drawing from #565 is better? You could help evaluate #565 (and improve?).
How many windows do you have per workspace and totally?

[danfe]

You could help evaluate #565 (and improve?)

Thanks for the hint, I'll take a look!

How many windows do you have per workspace and totally?

I have four workspaces with 4~12 xterm windows on each (plus windows for other programs, of course, but those usually do not require grouping and are per-workspace anyway).

[danfe]

I'm a bit surprised that when I enable it, it groups all windows across all worskspaces, not just those which belong to the current one. Is there a way to control this?

Gentle nag to (re)consider making this per-workspace or configurable. :-)

[danfe]

Feel kind of bad about nagging you again, but did you have a chance to think about making this configurable or maybe aligned with the TaskBarShowAllWindows setting? Global grouping by default essentially deprives me from using the taskbar for switching between my dozen xterm's while I'd gladly use it if grouping were per-workspace. Perhaps attached screenshot would be more convincing.

Another problem with global grouping is that selecting a window from the group might switch the current workspace, which can be confusing to the user (unless TaskBarShowAllWindows is enabled; +1 reason to make it aligned with that setting, if not configurable).

[danfe]

Let TaskBarShowAllWindows influence TaskBarTaskGrouping

Oh this is so much better now, can't thank you enough! :-)