-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve out-of-memory handling #68
Comments
What happened before you added the changes? |
PS: Do you think you can write a unit test? |
I've got a unit test in my code that fails without these changes. I'll try It was failing on something like this: jbtiny.parseObject() returns success. I knew that your intent was to make the invariants mutable, but I couldn't On Sun, Apr 26, 2015 at 7:49 AM, Benoît Blanchon notifications@github.com
Karl Lew |
Excellent! |
Cool. Thanks! I was trying to figure out the unit tests and that would take On Sun, Apr 26, 2015 at 8:08 AM, Benoît Blanchon notifications@github.com
Karl Lew |
I fixed the bug in a completely different way. |
Thanks, Benoit! Your fix feels much better than my bandaid. :D On Sun, Apr 26, 2015 at 11:01 AM, Benoît Blanchon notifications@github.com
Karl Lew |
Benoit, I made a few tweaks in my branch to handle several out-of-memory edge cases that were blowing up my code. You might be interested in this:
firepick1@bc8c3d9
The text was updated successfully, but these errors were encountered: