-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advertise ESP-IDF compatibility in library.json #1490
Conversation
Hi @maxgerhardt, Thank you very much for this PR 👍 After reading the documentation you sent, I think the right framework is Can you update your PR according to this? Thanks! Best regards, |
Hmm I'm not sure if it should advertise If it works, I'll modify this PR. |
extras/ci/platformio.sh
Outdated
@@ -1,6 +1,6 @@ | |||
#!/bin/sh -eux | |||
|
|||
pip install --user platformio | |||
pip3 install --user platformio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should revert this change; I fixed the CI in 3975b07
This reverts commit afabcf8.
The new CI issue should be fixed by 769e844. |
I'd like to include this change in version 6.17.3. |
Eh unfortunately not before tuesday :/ |
I published ArduinoJson 6.17.3 with @maxgerhardt, I think we still have to set |
Per PlatformIO forum thread this library can also be used with ESP-IDF. It's just that PlatformIO refuses by default to use this library in a project that has
framework = espidf
and notarduino
because thelibrary.json
only advertisesarduino
compatibility and a user needs to dolib_compat_mode = off
to bypass the compatibility check.Per docs I've expanded the
library.json
.You might also want to expand the detection code for
ArduinoJson/src/ArduinoJson/Configuration.hpp
Lines 23 to 34 in 322d13d
So that the macro ends up having the value 1, the same as in Arduino. The check
#if defined(IDF_VER)
might e.g. be used for that (defined during build process-DIDF_VER=\"3.40200.210118\"
), or check on__xtensa__
(compiler does#define __xtensa__ 1
). I left that out in this PR because I'm not 100% sure on what you want this macro value to be in an ESP-IDF environment.