Add extras folder to .mbedignore #1515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the extras folder to the .mbedignore file. Some code in the extras folder causes build failures when compiling for Mbed OS (shown below): ``` [Error] Issue1189.cpp@12,8: 'ArduinoJson6173_71::JsonDocument::JsonDocument(const ArduinoJson6173_71::JsonDocument&)' is private within this context [Error] Issue1189.cpp@12,8: 'ArduinoJson6173_71::JsonDocument::~JsonDocument()' is protected within this context ``` Among other errors. Simply ignoring this directory from the Mbed-OS build is sufficient to fix this problem.
|
Fantastic library by the way! Very beautiful API/syntax. 👏 |
|
Hi @AGlass0fMilk, Thank you for this contribution! Best Regards, |
bblanchon
requested changes
Mar 8, 2021
| @@ -4,3 +4,4 @@ fuzzing/ | |||
| scripts/ | |||
| test/ | |||
| third-party/ | |||
| extras/ | |||
There was a problem hiding this comment.
I think this is a good opportunity to remove old folders from the list (fuzzing, scripts, test, and third-party).
Can you do that?
There was a problem hiding this comment.
I have implemented this in dc33e42
|
PR squashed and merged. |
|
Fix published in ArduinoJson 6.18.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the extras folder to the .mbedignore file. Some code in the extras folder causes build failures when compiling for Mbed OS (shown below):
Among other errors. Simply ignoring this directory from the Mbed-OS build is sufficient to fix this problem.