Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set build.libArchive to false. #1550

Closed
wants to merge 1 commit into from
Closed

Conversation

askreet
Copy link
Contributor

@askreet askreet commented May 1, 2021

When attempting to build on the native platformIO framework, it attempts to compile a linkable .a despite this library being header-only. In #731 it was suggested to use libArchive (which did not seem to work) but the submitter eventually used lib_archive at the project level.

This is, I assume, a better fix as the project-level setting will apply to all dependencies. I was able to build with this setting, at least.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.04% when pulling a119e03 on askreet:native-bugfix into 2be528a on bblanchon:6.x.

@bblanchon bblanchon closed this in a88cf8f May 3, 2021
@bblanchon
Copy link
Owner

Hi Kyle,

Thank you very much for this PR 👍
I merged it with a88cf8f.

Best Regards,
Benoit

@bblanchon
Copy link
Owner

Fix published in ArduinoJson 6.18.0

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants