Added support for std::string_view #1554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @0xFEEDC0DE64, Thank you very much for this PR 👍 Best regards, |
bblanchon
added a commit
that referenced
this pull request
Jun 16, 2021
bblanchon
added a commit
that referenced
this pull request
Jun 16, 2021
bblanchon
added a commit
that referenced
this pull request
Jun 17, 2021
|
This feature is available in ArduinoJson 6.18.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was missing support for std::string_view in ArduinoJson, I don't have much knowledge about the internals of ArduinoJson and I tested my implementation only on ESP32 with esp-idf and without any arduino libraries.