Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to install a non-existent driver gives authorization error #207

Closed
smola opened this issue Nov 5, 2018 · 3 comments · Fixed by #213
Closed

Trying to install a non-existent driver gives authorization error #207

smola opened this issue Nov 5, 2018 · 3 comments · Fixed by #213
Assignees

Comments

@smola
Copy link
Member

smola commented Nov 5, 2018

From src-d/sourced-ce#104 (thanks @BFergerson):

I accidentally typed the command srcd parse drivers install list instead of srcd parse drivers list and received error:

INFO[0000] installing driver                             language=list version=latest
ERRO[0000] unable to install version latest of list driver: rpc error: code = Unknown desc = can't install list driver: rpc error: code = Unknown desc = errors:
denied: requested access to the resource is denied
unauthorized: authentication required

authentication required is an odd error for this mistaken command.

@dennwc
Copy link
Member

dennwc commented Nov 5, 2018

This error comes from the Dockerhub. We can detect it and rewrite an error message, but if you try to download a private Docker image without proper credentials, an error will be "cannot find the driver" which is also misleading. But I guess this is not a common use case right now, so overriding an error makes sense.

@smola
Copy link
Member Author

smola commented Nov 5, 2018

@dennwc We can also make it explicit in the error, something like The driver does not exist or it is private
or maybe The driver does not exist if it is bblfsh organization and The driver does not exist or it is private otherwise.

@bzz bzz self-assigned this Nov 20, 2018
@bzz
Copy link
Contributor

bzz commented Nov 20, 2018

Fixed in #213

@bzz bzz closed this as completed in #213 Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants