Graceful report for non-existing image #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanjux
approved these changes
Nov 20, 2018
dennwc
requested changes
Nov 21, 2018
|
All feedback addressed, tests added, error code analysis introduced instead of strings. Ready for another round @creachadair @dennwc |
dennwc
reviewed
Nov 22, 2018
dennwc
approved these changes
Nov 22, 2018
There was a problem hiding this comment.
Looks good! Thank you for implementing it :)
@creachadair Do you have any other feedback? If not, I'll merge it.
creachadair
approved these changes
Nov 26, 2018
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
On the clinet `bblfsctl` report if driver is missing for bblfsh org TEST PLAN: - $ go test - $ bblfshcrl driver install list -> `driver 'docker://list' does not exist` Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Co-Authored-By: bzz <bzz@users.noreply.github.com>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
|
All feedback addressed, going to merge as soon as CI is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
AlreadyInstalledstatus from d5b686f this change propagates the fact that image request is not found or needs to have authentication credentials though gRPCUnauthenticatedcode on thedriver installcommand.Before:
After:
It resolves #207 in a way it's been decided in that issue.
While at it, few other small fixes included:
dep ensurebblfshctl -ctl-endpoint->bblfshctl -ctl-networkfor consistency, same as it is inbblfshd