-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][vendoring] Rename simple-linguist to enry #38
Conversation
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
========================================
Coverage ? 60.2%
========================================
Files ? 13
Lines ? 691
Branches ? 0
========================================
Hits ? 416
Misses ? 235
Partials ? 40
Continue to review full report at Codecov.
|
@@ -223,7 +223,7 @@ imports: | |||
- transport | |||
- name: gopkg.in/src-d/go-errors.v0 | |||
version: 0c303ec4c027302259ec1738f19f515aad25f13f | |||
- name: gopkg.in/src-d/simple-linguist.v1 | |||
- name: gopkg.in/src-d/enry.v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stupid question: Shouldn't we use github.com/src-d/enry
instead now that we are versioning using commits?
Now that we are using glide, what we want is to use a particular commit from github.com/src-d/enry
, not from gopkg.in/src-d/enry.v1
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alcortesm We cannot do this because all the internal enry imports are using gopkg.in/src-d/enry.v1 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajnavarro that's right. But our internal imports use gopkg.in/src-d/enry.v1
because we were not using glide before and we needed some way to import a particular version. Now that we are using glide, that should no longer be the case.
What I am talking about is to start importing github.com/src-d/enry
everywhere, now that thanks to glide, we no longer need to use URL redirects to simulate versioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, at this point I don't know what we should or shouldn't be doing with respect to versioning, is there any document or meeting minute detailing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to use the sale import that the library defines. Enry does use gopkg.in in it's importa, so we do it too. Glide cannot change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use an alias for the package, use it's name.
@juanjux I've just merged another PR renaming the package, please, rebase. |
@smola actually, something is probably odd in enry because I tried that but if I just import the module without any aliasing and then use enry as the module, the travis build fails with:
I'll try importing and aliasing as |
@juanjux yep, forgot to update the glide stuff. |
Simple rename of simple-linguist to enry in the Glide files and one source file. This actually fix the build of the server for me (previously it gave an error about an "internal reference" to a module), which should not happen since in theory they're the same tags but happens anyway.