enable CORS on REST server #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
force-pushed
the
feature/cors
branch
from
d3e7638 to
848f920
Compare
juanjux
approved these changes
Jun 28, 2017
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 59.48% 59.75% +0.27%
==========================================
Files 15 15
Lines 733 738 +5
==========================================
+ Hits 436 441 +5
Misses 256 256
Partials 41 41
Continue to review full report at Codecov.
|
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
feature/cors
branch
from
848f920 to
6eef12d
Compare
Serabe
approved these changes
Jun 28, 2017
smola
approved these changes
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I allowed all origins but restricted credentials, methods and headers.
/cc @smola @juanjux @abeaumont @Serabe @dpordomingo