Handle dropped fields in methods #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 15, 2019 17:42
Signed-off-by: Denys Smirnov <denys@sourced.tech>
Signed-off-by: Denys Smirnov <denys@sourced.tech>
Signed-off-by: Denys Smirnov <denys@sourced.tech>
added 2 commits
February 15, 2019 19:56
Signed-off-by: Denys Smirnov <denys@sourced.tech>
Signed-off-by: Denys Smirnov <denys@sourced.tech>
dennwc
changed the title
juanjux
reviewed
Feb 18, 2019
juanjux
approved these changes
Feb 18, 2019
creachadair
reviewed
Feb 18, 2019
|
@creachadair @bzz Ready for another round. As soon as it's ready, I would say we can release v1.0. |
creachadair
reviewed
Feb 19, 2019
bzz
reviewed
Feb 19, 2019
driver/normalizer/normalizer.go
Outdated
| "Type": UASTType(uast.FunctionType{}, dstType), | ||
| // If the function was defined with an arrow expression, we will | ||
| // generate a uast:Block with a since csharp:Return node containing |
There was a problem hiding this comment.
Not sure I can understand this sentence generate a uast:Block with a ...? since csharp:Return node containing
There was a problem hiding this comment.
Thanks! Fixed the typo in the latest commit.
Signed-off-by: Denys Smirnov <denys@sourced.tech>
dennwc
force-pushed
the
handle_fields_func_1
branch
from
099d8e9 to
b372b4a
Compare
creachadair
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle all dropped fields for method/constructor/destructor declarations:
Finally fixes #19
See comments in the code for more details.