Style fixes #22
Style fixes #22
Conversation
* Remove unneded find context creation function from public API * Remove interface getter from public API * Rename types, variables and functions to: - Make them consistent - Make them more easily understandable (i.e. Nodes vs FindCtx)
| #include "roles.h" | ||
|
|
||
| #include <stddef.h> | ||
|
|
||
| static const char *id_to_roles[] = {`) | ||
|
|
||
| for i := 0; i < int(lastRole); i++ { |
There was a problem hiding this comment.
Lower Camel case (lastRole).
There was a problem hiding this comment.
This is Go code, not C.
| @@ -11,7 +11,7 @@ bool fail_xmlAddChild = false; | |||
| bool fail_xmlXPathNewContext = false; | |||
There was a problem hiding this comment.
Lower Camel case and underline, but I guess this is because of the xml lib? (there are others below like xmlChar, xmlVersion, etc).
There was a problem hiding this comment.
I think in this case is a good idea to leave them as they're for readability reasons.
tests/main.cc
Outdated
| } | ||
|
|
||
| // add a suite to the registry | ||
| CU_pSuite pSuite = CU_add_suite("Suite_1", NULL, NULL); |
There was a problem hiding this comment.
Lower Camel case (pSuite, also many others in this file).
tests/nodes_test.h
Outdated
| return true; | ||
| } | ||
|
|
||
| void testUastNew() { |
There was a problem hiding this comment.
Google conventions require functions to start with uppercase, but I don't know if here the testing framework defines the naming.
There was a problem hiding this comment.
I thought so, but apparently not.
Should solve #16