Fix failing Async::HTTP specs due to Async API change #1040
Conversation
The `async` gem recently made a breaking API change that was released in patch version 2.6.4.[^1] Following the change, async tasks that return an exception object will no longer raise that exception when `wait` is called. The `Async::HTTP` specs in webmock were written to leverage the old behavior of `wait`. Since async 2.6.4 was released, these specs have been failing in CI. This commit fixes the failing specs by updating how `wait` is used, such that exceptions are still raised as expected in async 2.6.4. This should restore CI to a working state. [^1]: socketry/async#270
| end.wait | ||
|
|
||
| result.is_a?(Exception) ? raise(result) : result |
There was a problem hiding this comment.
🗒️ Before async 2.6.4, wait would raise an exception if the task returned an exception object (in this case, Async::TimeoutError). Since 2.6.4, wait no longer raises the exception, it just returns it as an exception object.
The webmock specs rely on the exception being raised, so I added this ternary line to restore the old wait behavior.
|
Looks like this PR is restoring Ruby 3.1 and 3.2 to green status in CI. 🎉 As a separate issue, Ruby head is failing due to the |
|
@mattbrictson big thanks for the thorough investigation and the fix! 🙏 |
The
asyncgem recently made a breaking API change that was released in patch version 2.6.4.1 Following the change, async tasks that return an exception object will no longer raise that exception whenwaitis called.The
Async::HTTPspecs in webmock were written to leverage the old behavior ofwait. Since async 2.6.4 was released, these specs have been failing in CI.This commit fixes the failing specs by updating how
waitis used, such that exceptions are still raised as expected in async 2.6.4. This should restore CI to a working state.Fixes #1036
Footnotes
https://github.com/socketry/async/pull/270 ↩