Resolve net-http adapter deprecation Ruby 3.4
#1081
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
net-http-adapter-ruby-3.4
branch
from
4cfa886 to
720c41c
Compare
Earlopain
force-pushed
the
net-http-adapter-ruby-3.4
branch
from
720c41c to
f58b1f8
Compare
|
Slight gearshift. The constant will be kept for 3.4 but will warn on removal, see https://bugs.ruby-lang.org/issues/20900. I adapted the code to not warn and handle the const removal. |
koic
reviewed
Nov 19, 2024
Comment on lines
46
to
52
| def self.remove_silently(mod, const) #:nodoc: | ||
| begin | ||
| # Don't warn on removing the deprecated constant | ||
| verbose, $VERBOSE = $VERBOSE, nil | ||
| mod.send(:remove_const, const) | ||
| ensure | ||
| $VERBOSE = verbose | ||
| end | ||
| end |
There was a problem hiding this comment.
My two cents, WebMock supports Ruby 2.5+, the redundant begin should no longer be necessary.
https://github.com/bblimke/webmock/blob/v3.24.0/webmock.gemspec#L24
Suggested change
| def self.remove_silently(mod, const) #:nodoc: | |
| begin | |
| # Don't warn on removing the deprecated constant | |
| verbose, $VERBOSE = $VERBOSE, nil | |
| mod.send(:remove_const, const) | |
| ensure | |
| $VERBOSE = verbose | |
| end | |
| end | |
| def self.remove_silently(mod, const) #:nodoc: | |
| # Don't warn on removing the deprecated constant. | |
| verbose, $VERBOSE = $VERBOSE, nil | |
| mod.send(:remove_const, const) | |
| ensure | |
| $VERBOSE = verbose | |
| end |
This old constant was deprecated in 2001 and will now be removed in Ruby 3.5
On Ruby 3.4, removing a deprecated constant will warn:
> /home/user/code/webmock/lib/webmock/http_lib_adapters/net_http.rb:55: warning: constant Net::HTTPSession is deprecated
It fixes this error on Ruby 3.5:
```
/usr/local/bundle/bundler/gems/webmock-9ff63ac7c845/lib/webmock/http_lib_adapters/net_http.rb:25:in 'Module#remove_const': constant Net::HTTPSession not defined (NameError)
Net.send(:remove_const, :HTTPSession)
^^^^^
from /usr/local/bundle/bundler/gems/webmock-9ff63ac7c845/lib/webmock/http_lib_adapters/net_http.rb:25:in 'WebMock::HttpLibAdapters::NetHttpAdapter.disable!'
```
Earlopain
force-pushed
the
net-http-adapter-ruby-3.4
branch
from
f58b1f8 to
67c0695
Compare
Earlopain
changed the title
net-http adapter for Ruby 3.4net-http adapter deprecation Ruby 3.4
|
@bblimke could you check this out? The next Ruby version is only about 2 weeks away now. |
|
Hello 😃, All Rails apps that try to update to Ruby 3.4.1 will see a warning because of this 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This old constant was deprecated in 2001 and now finally removed. ruby/net-http#189
It fixes this error:
You can test it yourself by adding
gem 'net-http', github: 'ruby/net-http'to the gemfile here and running tests.I assume this will be released with 3.4