Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vhd support #1

Merged

Conversation

bbonaby
Copy link
Owner

@bbonaby bbonaby commented Aug 7, 2024

Merge conflict resolution from Main to PR branch

PlagueHO and others added 5 commits March 16, 2024 10:24
 dsccommunity#285 (dsccommunity#286)

- OpticalDiskDriveLetter:
  - Fix detection of virtual optical drives by changing logic to detect how
    a mounted ISO is detected. This resolves issues with using the resource
    in Azure Gen2 VMs with Windows Server 2022 Azure Edition - Fixes (issue dsccommunity#285).
- Azure DevOps Build Pipeline:
  - Tests 'Unit (Windows Server 2022)' corrected to execute on Windows Server
    2022 node instead of Windows Server 2019.
  - 'Package Module' job runs on 'windows-latest' hosted agent to resolve
    'Unable to load shared library 'libmi' or one of its dependencies.' error.
- Disk:
  - Fixed unit test failure loading `StorageDsc.Common.strings` due to change in
    `DscResource.Common\Get-LocalizationData` in PR dsccommunity#109.
@bbonaby bbonaby merged commit 2798946 into light-up-dev-drive-and-add-vhd-creation-support Aug 7, 2024
bbonaby added a commit that referenced this pull request Sep 16, 2024
…sccommunity#279)

* Add initial changes to add a Vhd resource and light up DSC_Disk to allow volumes to be formatted as Dev Drives

* update comments and add parameter validation to string parameters

* update win32helpers so we can add tests

* add more tests

* Add more unit tests

* add more tests for the win32 helper

* update comments

* update synopsis and fix test

* fix failing tests

* fix hqrmtests and add test coverage for disk type is fixed scenario

* fix more hqrmtest failures that don't show up in ps5.1 but show up in ps 7

* update resource to add more description about usage and limitations and use safefilehandles instead of closehandle function

* remove no longer used function

* Merge branch 'main' into light-up-dev-drive-and-add-vhd-creation-support

* update based on comments, reword md file, and add parameter names to function calls in win32helpers

* update readme file

* remove spaces in psd1 tags

* Merge branch 'main' into light-up-dev-drive-and-add-vhd-creation-support

* Merge branch 'main' into light-up-dev-drive-and-add-vhd-creation-support

* Merge branch 'main' into update-vhd-support

* Merge pull request #1 from bbonaby/update-vhd-support

Update vhd support

* update based on PR comments and add an IsAdmin check

* update pipeline based on comments

* Add virtual hard disk integration tests

* Fix unit test

* update based on comments

Co-Authored-By: U-BRANX-PC\brand <brandonbonaby94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants