Only include translated items if they exist in the en destination file

bbondy · Sep 4, 2019 · 2baf61d · 2baf61d
1 parent 4dfc702
commit 2baf61d
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/sync-strings.js b/sync-strings.js
@@ -26,7 +26,7 @@ const getLangStringsMap = (dir) => {
 const filterLangs = (lang) =>
   !['index.json', 'en'].includes(lang)
 
-const syncLangStrings = (destDir, sourceLangStringsMap) => {
+const syncLangStrings = (destDir, sourceLangStringsMap, destLangStringsMap) => {
   fs.readdirSync(destDir)
     .filter(filterLangs)
     .forEach((lang) => {
@@ -46,8 +46,12 @@ const syncLangStrings = (destDir, sourceLangStringsMap) => {
       }
       Object.keys(langMap).forEach((key) => {
         if (sourceLangStringsMap[lang][key] || newFile) {
-          langMap[key].message =
-            formattingFixer(brandingFixer(sourceLangStringsMap[lang][key]))
+          // Make sure that the source language contains the string to be translated
+          // This avoids keeping translations for removed strings
+          if (destLangStringsMap.en[key]) {
+            langMap[key].message =
+              formattingFixer(brandingFixer(sourceLangStringsMap[lang][key]))
+          }
         }
       })
       const data = JSON.stringify(langMap, null, 2)
@@ -83,10 +87,11 @@ const syncStrings = (sourceDir, destDir) => {
   assertDirExists(destDir)
 
   const sourceLangStringsMap = getLangStringsMap(sourceDir)
+  const destLangStringsMap = getLangStringsMap(destDir)
   const sourceLangs = Object.keys(sourceLangStringsMap)
 
   syncDirs(destDir, sourceLangs)
-  syncLangStrings(destDir, sourceLangStringsMap)
+  syncLangStrings(destDir, sourceLangStringsMap, destLangStringsMap)
 
   console.log(`Syncing from sourceDir: ${sourceDir} to destDir: ${destDir}`)