Always invoke async success/exception handlers even if set after sending email (behaving more like promises/futures)

[Dornaut]

I'm using simple-java-mail 6.4.3 with batch-module and try to understand how is it guaranteed for onSuccess and onException handlers that their setting will be performed before their usage?

AsyncOperationHelper contains comment

simple-java-mail/modules/batch-module/src/main/java/org/simplejavamail/internal/batchsupport/AsyncOperationHelper.java

Line 59 in 2ec2162

// by the time the code reaches here, the user would have configured the appropriate handlers

But if I correctly understand it's still possible (if inner NamedRunnable will be executed fast) that

simple-java-mail/modules/batch-module/src/main/java/org/simplejavamail/internal/batchsupport/AsyncOperationHelper.java

Line 62 in 2ec2162

asyncResponseRef.get().delegateSuccessHandling();

will be executed before the user will set corresponding callback in main thread

E.g. I tried to perform simple test based on example from site:

AsyncResponse asyncResponse = mailer.sendMail(email, true);
asyncResponse.onSuccess(() -> System.out.println("Success"));
asyncResponse.onException((e) -> System.err.println("error"));

In this case the callback was executed successfully.
But if the main thread will sleep for some time, e.g.

AsyncResponse asyncResponse = mailer.sendMail(email, true);
Thread.sleep(10000);
asyncResponse.onSuccess(() -> System.out.println("Success"));
asyncResponse.onException((e) -> System.err.println("error"));

The callback was not executed at all because

simple-java-mail/modules/batch-module/src/main/java/org/simplejavamail/internal/batchsupport/AsyncResponseImpl.java

Line 39 in 860a0d5

void delegateSuccessHandling() {

was called when onSuccess method was not called yet and successHandler was still null.

Do I understand something wrong or is it a bug?

This can probably be solved if callbacks will be passed directly into the sendMail method and then directly into the AsyncResponseImpl constructor

simple-java-mail/modules/batch-module/src/main/java/org/simplejavamail/internal/batchsupport/AsyncOperationHelper.java

Line 56 in 2ec2162

asyncResponseRef.set(new AsyncResponseImpl(executorService.submit(new NamedRunnable(processName) {

[bbottema]

Excellent report, thank you! I will look into it this week. Seems like a bug to me.

[Dornaut]

@bbottema Thank you! We would really appreciate it.

[bbottema]

So the assumption is that the user would set the handlers right after calling the send method, which should always take less time than sending the email, even when it's set to skip sending and only log. So in practice this shouldn't be an issue, but I agree it's not a very elegant approach.

I'll change this behavior to be more in line with how promised/futures work so the handlers will always be invoked.

[bbottema]

Released in 6.4.4.