Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic module names (fixes #245) #247

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Feb 2, 2020

This PR adds proper automatic module names to every JAR in the project. They can be checked inside the JAR's META-INF/MANIFEST.MF. Some things to consider before merging:

  • People will reference these names in their module descriptors. Therefore, they should be considered public API. Please review these names and make sure you are comfortable with them, before you make them permanent.
  • These names should become the proper module names, if/when multi-release jar for jdk11+ missing #237 is worked on. The project can now be included in modular Java applications, but to achieve full modularity, the modules of this project should provide their own module descriptors.

Word of caution: on my Java 11, I still wasn't able to build the project cleanly. I have to -DskipTests, as plenty of tests fail with Java 11. (This PR has no effect on that, neither should it.) Also, for some reason, JaCoCo also throws a lot of exceptions, although I don't have that problem with my own projects using it.

@triceo triceo requested a review from bbottema February 2, 2020 12:24
@bbottema bbottema merged commit 5839715 into bbottema:develop Feb 5, 2020
@triceo triceo deleted the jpms branch February 5, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants