Add automatic module names (fixes #245) #247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds proper automatic module names to every JAR in the project. They can be checked inside the JAR's
META-INF/MANIFEST.MF
. Some things to consider before merging:Word of caution: on my Java 11, I still wasn't able to build the project cleanly. I have to
-DskipTests
, as plenty of tests fail with Java 11. (This PR has no effect on that, neither should it.) Also, for some reason, JaCoCo also throws a lot of exceptions, although I don't have that problem with my own projects using it.