Update to .NET Standard, test project using .NET Core 3 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <ItemGroup> | ||
| <Reference Include="MsSpellCheckLib"> | ||
| <HintPath>..\..\lib\MsSpellCheckLib.dll</HintPath> | ||
| <EmbedInteropTypes>True</EmbedInteropTypes> |
There was a problem hiding this comment.
EmbedInteropTypes is important and the reason netstandard2.0 surface area can't be supported. I have another branch with a .net core conversion attempt that was waiting on netstandard2.1 or netcoreapp3.0 with the appropriate interop interfaces. Now that that has been released I'll complete that first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like 2 of the unit tests are failing and continue to fail after the update. Since this is just a wrapper and the upstream was failing I'm not looking into this right now.