Support patching r25 NDK with quoting workaround on Windows #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rib
force-pushed
the
ndk-25-quoting-workaround
branch
from
10a7234 to
7e0c9ed
Compare
This is an alternative fix for bbqsrc#92 that avoids hitting command line length limitations and avoid needing to use `cargo-ndk` as a spring board for running `clang`, which avoids needing temporary hard links or copying the `cargo-ndk` binary to the target/ directory. By default cargo-ndk will just emit an error message if it recognises the current NDK needs a quoting workaround, and will also emit a warning suggesting to re-run with `--apply-ndk-quote-workaround` so that `cargo-ndk` can automatically apply the required workaround.
rib
force-pushed
the
ndk-25-quoting-workaround
branch
from
7e0c9ed to
31c8e31
Compare
This was referenced May 17, 2023
|
I think at this point #107 (which avoids using the Clang wrappers altogether) is probably a better solution compared to this. |
|
Closing this for now in favor of #108 as a solution instead - can potentially re-open later if it makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for #92 that avoids hitting command line length limitations and avoid needing to use
cargo-ndkas a spring board for runningclang, which avoids needing temporary hard links or copying thecargo-ndkbinary to the target/ directory.By default cargo-ndk will just emit an error message if it recognises the current NDK needs a quoting workaround, and will also emit a warning suggesting to re-run with
--apply-ndk-quote-workaroundso thatcargo-ndkcan automatically apply the required workaround.If
--apply-ndk-quote-workaroundis passed thencargo ndkwill replace lines matchingif "%1" == "-cc1" goto :Lwithif "%~1" == "-cc1" goto :Lin the CC and CXX.cmdfiles which will avoid any double quotes when checking if the first argument == "-cc1".Fixes #104