Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make terms configurable #3

Merged
merged 5 commits into from
Jun 21, 2022
Merged

Make terms configurable #3

merged 5 commits into from
Jun 21, 2022

Conversation

zaherg
Copy link
Contributor

@zaherg zaherg commented Jun 20, 2022 •
edited
Loading

  • This PR add the ability to configure the term/terms we are looking for inside our code,
  • while also ignoring the .github directory.
  • The default value for the terms is FIXME (for backward compatibly).

Example

name: Linters

on: [push]

jobs:
  fixmes:
    name: FIXME check
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v1
    - uses: bbugh/action-fixme-check@master # or @ the latest release
      with:
      	terms: 'wip|fixme'

Note
I added a few test statements to the README file, so feel free to remove them.

This PR should close #2 once it is merged.

image

tillkruss
tillkruss suggested changes Jun 20, 2022
View reviewed changes
.github/workflows/test.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
bbugh
bbugh requested changes Jun 20, 2022
View reviewed changes
Copy link
Owner

@bbugh bbugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zaherg for the PR! A few changes and we can merge.

action.yml Outdated Show resolved Hide resolved
lib/entrypoint.sh Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bbugh
Copy link
Owner

bbugh commented Jun 20, 2022

Thanks @zaherg for the PR and @tillkruss for the preliminary PR review!

@zaherg zaherg requested a review from bbugh June 21, 2022 09:13
bbugh
bbugh requested changes Jun 21, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
lib/entrypoint.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
zaherg and others added 2 commits June 21, 2022 18:29
@zaherg @bbugh
Update README.md
96fb8bd 
Co-authored-by: Brian Bugh <438465+bbugh@users.noreply.github.com>
@zaherg @bbugh
Update lib/entrypoint.sh
7dcad82 
Co-authored-by: Brian Bugh <438465+bbugh@users.noreply.github.com>
@zaherg zaherg requested a review from bbugh June 21, 2022 15:31
@bbugh bbugh merged commit 301f4db into bbugh:master Jun 21, 2022
@bbugh
Copy link
Owner

bbugh commented Jun 21, 2022

Thanks @zaherg! Feel free to do another PR with the case changes.

@zaherg
Copy link
Contributor Author

zaherg commented Jun 21, 2022

Already did, when you have time check the new PR 😅

@bbugh
Copy link
Owner

bbugh commented Jun 21, 2022

Released in https://github.com/bbugh/action-fixme-check/releases/tag/v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss tillkruss requested changes

@bbugh bbugh bbugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make terms configurable
3 participants
@zaherg @bbugh @tillkruss