Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the search sensitivity configurable #4

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Make the search sensitivity configurable #4

merged 2 commits into from
Jun 21, 2022

Conversation

zaherg
Copy link
Contributor

@zaherg zaherg commented Jun 21, 2022

Added the case-sensitive option.

@bbugh bbugh self-requested a review June 21, 2022 17:58
Copy link
Owner

@bbugh bbugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't been requested as a review so I didn't see it, sorry about that.

It looks like the checks claim to be passing, but there are failure annotations in the diff: https://github.com/bbugh/action-fixme-check/pull/4/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

Seems like something isn't working quite right.

@zaherg
Copy link
Contributor Author

zaherg commented Jun 21, 2022

@bbugh I can't request a review unless I am a member (or contributor) this is why you didn't get any request.

It looks like the checks claim to be passing, but there are failure annotations in the diff: https://github.com/bbugh/action-fixme-check/pull/4/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
Seems like something isn't working quite right.

If I am not mistaken, they are passing because we have the test environment is set which prevent from exiting with an error status.

And the whole idea from the tests is to show the annotations in the files and the summary (correct me if I am wrong) whenever they find any of the terms in the code, which is exactly what happened here.

@zaherg zaherg requested a review from bbugh June 21, 2022 18:52
@bbugh
Copy link
Owner

bbugh commented Jun 21, 2022

@zaherg you're absolutely right. It's been so long since I set this up. Thank you for the effort, looks good!

@bbugh bbugh merged commit 82f548e into bbugh:master Jun 21, 2022
@bbugh
Copy link
Owner

bbugh commented Jun 21, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants