Fixes doctrine#2306. Adds support for a connect string when using Oci8

bburnichon · Jun 16, 2016 · 6224dc9 · 6224dc9
1 parent feadeba
commit 6224dc9
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/docs/en/reference/configuration.rst b/docs/en/reference/configuration.rst
@@ -296,6 +296,8 @@ pdo\_oci / oci8
    add the INSTANCE_NAME parameter in the connection. It is generally used
    to connect to an Oracle RAC server to select the name of a particular instance.
 
+Complete connection descriptors are also supported. You only need to provide the following parameter, and none of the above:
+- ``connectstring`` (string): Complete Easy Connect connection descriptor, see https://docs.oracle.com/cd/E11882_01/network.112/e41945/naming.htm.
 
 pdo\_sqlsrv / sqlsrv
 ^^^^^^^^^^^^^^^^^^^^

diff --git a/lib/Doctrine/DBAL/Driver/AbstractOracleDriver.php b/lib/Doctrine/DBAL/Driver/AbstractOracleDriver.php
@@ -109,10 +109,15 @@ public function getSchemaManager(\Doctrine\DBAL\Connection $conn)
      *
      * @return string
      *
-     * @link http://download.oracle.com/docs/cd/E11882_01/network.112/e10836/naming.htm
+     * @link https://docs.oracle.com/cd/E11882_01/network.112/e41945/naming.htm
      */
     protected function getEasyConnectString(array $params)
     {
+
+        if ( ! empty($params['connectstring'])) {
+            return $params['connectstring'];
+        }
+
         if ( ! empty($params['host'])) {
             if ( ! isset($params['port'])) {
                 $params['port'] = 1521;

diff --git a/tests/Doctrine/Tests/DBAL/Driver/AbstractOracleDriverTest.php b/tests/Doctrine/Tests/DBAL/Driver/AbstractOracleDriverTest.php
@@ -25,6 +25,25 @@ public function testReturnsDatabaseName()
         $this->assertSame($params['user'], $this->driver->getDatabase($connection));
     }
 
+    public function testReturnsDatabaseNameWithConnectDescriptor()
+    {
+        $params = array(
+            'user'             => 'foo',
+            'password'         => 'bar',
+            'connectionstring' => '(DESCRIPTION=' .
+                '(ADDRESS=(PROTOCOL=TCP)(HOST=localhost)(PORT=1521))' .
+                '(CONNECT_DATA=(SERVICE_NAME=baz)))'
+        );
+
+        $connection = $this->getConnectionMock();
+
+        $connection->expects($this->once())
+            ->method('getParams')
+            ->will($this->returnValue($params));
+
+        $this->assertSame($params['user'], $this->driver->getDatabase($connection));
+    }
+
     protected function createDriver()
     {
         return $this->getMockForAbstractClass('Doctrine\DBAL\Driver\AbstractOracleDriver');