Fix type check for args passed to add_words() #44
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tobyink and @perlpunk worked out in https://rt.cpan.org/Public/Bug/Display.html?id=144672 that the closing square brace in the types check to the `add_words` sub was not in the correct place. As mentioned by @tobyink in the RT ticket: > Versions of Type::Params prior to 2.000000 would not have spotted this mistake @perlpunk provided the patch which I'm submitting in this commit. This change makes the test suite pass again and would hence close both issue bbusschots#42 and issue bbusschots#38.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tobyink and @perlpunk worked out in
https://rt.cpan.org/Public/Bug/Display.html?id=144672 that the closing square brace in the types check to the
add_wordssub was not in the correct place. As mentioned by @tobyink in the RT ticket:@perlpunk provided the patch which I'm submitting in this commit.
This change makes the test suite pass again and would hence close both issue #42 and issue #38.
This PR is submitted in the hope that it is useful. If you need anything changed, please don't hesitate to let me know and I'll be more than happy to update and resubmit as necessary.