Skip to content

Commit

Permalink
Fix icon on OSX
Browse files Browse the repository at this point in the history
  • Loading branch information
@nyancrimew
nyancrimew committed Jan 17, 2017
1 parent 2b60967 commit 7266f28
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion app/main.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@
"height": config.get("height"),
"minWidth": 600,
"minHeight": 600,
"icon": __dirname + 'assets/icon/icon.png',
//"type": "toolbar",
"title": "WhatsApp",
"webPreferences": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"clean:linux": "rm -rf ./dist/WhatsApp-linux-x64",
"build": "npm run clean && npm run build:osx && npm run build:win && npm run build:linux",
"build:win": "npm run clean:win && electron-packager ./app \"WhatsApp\" --out=dist --platform=win32 --arch=x64 --version=0.37.3 --icon=assets/win/whatsapp.ico",
"build:osx": "npm run clean:osx && electron-packager ./app \"WhatsApp\" --out=dist --platform=darwin --arch=x64 --version=0.37.3 --icon=assets/osx/WhatsApp.icns",
"build:osx": "npm run clean:osx && electron-packager ./app \"WhatsApp\" --out=dist --platform=darwin --arch=x64 --version=0.37.3 --icon=assets/osx/whatsapp.icns",
"build:linux": "npm run clean:linux && electron-packager ./app \"WhatsApp\" --out=dist --platform=linux --arch=x64 --version=0.37.3 --icon=assets/win/whatsapp.ico"
},
"devDependencies": {
Expand Down

1 comment on commit 7266f28

@imsys
Copy link
Contributor

@imsys imsys commented on 7266f28 May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of the icon attribute in app/main.js necessary to work on OSX? That edit breaks the icon in Linux if I run the app directly using the electron command.

Please sign in to comment.