-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add BccDialog component to design library #307
base: main
Are you sure you want to change the base?
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-coast-028fe6203-307.westeurope.3.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-coast-028fe6203-307.westeurope.3.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels really similar to the modal - why is this a separate component? Can we instead adjust the modal component so we don't need two components for roughly the same functionality?
Good question, these are a two seperate components in DS and are used in different scenarios I suppose, so I am not sure what the strategy would be. If that makes sense I can just adjust the modal, and maybe designers could just change the dialog names to modals @laurensgroeneveld |
@lukaspoloki Yes that would be my preference, otherwise we have to maintain two almost identical components 😅 And also makes it less clear for developers which one they should take. |
@laurensgroeneveld the more I think about it, the less sense it makes to merge these two, as there are different use-cases. For example, modals are not destructive, and the buttons are not stretched to the full width in modals. Merging them would make the implementation quite messy |
@lukaspoloki sorry for the delay looking at this. I agree with Laurens' comment that it's similar to the modal. If there still is a need for unique behaviour in the |
Change summary
Change type
Closes #306