Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add BccDialog component to design library #307

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lukaspoloki
Copy link
Collaborator

@lukaspoloki lukaspoloki commented May 15, 2024

Change summary

Change type

  • No review
  • Small PR
  • Big PR
  • Refactor

Closes #306

@lukaspoloki lukaspoloki self-assigned this May 15, 2024
@lukaspoloki lukaspoloki linked an issue May 15, 2024 that may be closed by this pull request
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-coast-028fe6203-307.westeurope.3.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-coast-028fe6203-307.westeurope.3.azurestaticapps.net

Copy link
Collaborator

@laurensgroeneveld laurensgroeneveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels really similar to the modal - why is this a separate component? Can we instead adjust the modal component so we don't need two components for roughly the same functionality?

@lukaspoloki
Copy link
Collaborator Author

Good question, these are a two seperate components in DS and are used in different scenarios I suppose, so I am not sure what the strategy would be. If that makes sense I can just adjust the modal, and maybe designers could just change the dialog names to modals @laurensgroeneveld

@laurensgroeneveld
Copy link
Collaborator

@lukaspoloki Yes that would be my preference, otherwise we have to maintain two almost identical components 😅 And also makes it less clear for developers which one they should take.

@lukaspoloki
Copy link
Collaborator Author

@laurensgroeneveld the more I think about it, the less sense it makes to merge these two, as there are different use-cases. For example, modals are not destructive, and the buttons are not stretched to the full width in modals. Merging them would make the implementation quite messy

@StevenMalaihollo
Copy link
Contributor

@lukaspoloki sorry for the delay looking at this.

I agree with Laurens' comment that it's similar to the modal. If there still is a need for unique behaviour in the BccModal component, I'd prefer adding a context: 'modal' | 'default' prop. Also because the code of BccModal vs BccDialog is largely copied over. But maybe I am missing some aspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BccDialog
3 participants