Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update directus #1016

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

chore: update directus #1016

wants to merge 11 commits into from

Conversation

andreasgangso
Copy link
Member

@andreasgangso andreasgangso commented Sep 28, 2024

The migrations

  • Directus added a new table "access policies". Permissions now point to policies instead of roles. Some of the fields that were previously on "role" got moved to policies. The policies got the same uuid as the roles, so its a simple operation to move the relations (UPDATE "public"."directus_permissions" SET "role" = "policy";).
  • directus_access is a new junction table to connect roles (or users) to policies.

Other things

  • Move modules into the extensions folder directly. This was a breaking change in v10 changelog
  • Updated all the cms and extensions' npm packages
  • Just some makefile and documentation tweaks that were convenient to do while I was working

Risks

  • Updated major versions for so although things build there could be changes in behavior.
  • Hard to confirm locally if all the extensions work as they should. The most critical extension to keep an eye out for is the pubsub hooks.
  • We might start seeing some errors in admin because directus has become stricter: "Requests for Missing Fields Now Fail". I noticed and fixed one such case where a directus_fields row for timedmetadata still had timestamp (we renamed it to seconds at some point).

I believe this is a more sane default for directus because we very rarely run this script. Theres a very real risk of quickly falling behind in the js ecosystem. And so that rare time we do update directus, we should invest by being a bit aggressive and willing to take the time to fix whatever breaking changes arise.
@andreasgangso andreasgangso changed the base branch from master to develop September 28, 2024 22:23
@andreasgangso andreasgangso removed the request for review from KillerX September 28, 2024 22:25
@andreasgangso andreasgangso marked this pull request as draft September 28, 2024 22:25
@andreasgangso
Copy link
Member Author

andreasgangso commented Sep 28, 2024

noticed some issues with the ui extensions, moving to draft.
edit: fixed

@andreasgangso andreasgangso marked this pull request as ready for review September 28, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant