Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace magikon step with @huggingface #9

Merged
merged 7 commits into from
Dec 26, 2024
Merged

ci: replace magikon step with @huggingface #9

merged 7 commits into from
Dec 26, 2024

Conversation

bcdady
Copy link
Owner

@bcdady bcdady commented Dec 26, 2024

This pull request includes changes to the GitHub Actions workflows to update the CI configuration and the schedule format for the Semgrep workflow. The most important changes are listed below:

CI Workflow Updates:

  • Renamed the workflow from "CI" to "Release project" and updated the job name from tag to release in .github/workflows/ci.yml.
  • Replaced the Github semantic tagging step with Checkout repository and Release steps using the huggingface/semver-release-action in .github/workflows/ci.yml.

Semgrep Workflow Updates:

  • Modified the cron schedule format to use double quotes instead of single quotes in .github/workflows/semgrep.yml.

@bcdady bcdady self-assigned this Dec 26, 2024
Comment on lines 15 to 23
name: Release
runs-on: ubuntu-latest

steps:
- name: Github semantic tagging
uses: Magikon/github-tag-action@5.0.0

- name: Checkout repository
uses: actions/checkout@v4

- name: Release
uses: huggingface/semver-release-action@latest

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions Job or Workflow does not set permissions
.github/workflows/ci.yml Fixed Show fixed Hide fixed
uses: actions/checkout@v4

- name: Release
uses: huggingface/semver-release-action@v1.1.0

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Release project' step
Uses Step
uses 'huggingface/semver-release-action' with ref 'v1.1.0', not a pinned commit hash
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@bcdady bcdady changed the title Hugging face ci: replace magikon step with @huggingface Dec 26, 2024
bcdady and others added 6 commits December 25, 2024 22:41
Signed-off-by: Bryan Dady <bryan@dady.us>
Signed-off-by: Bryan Dady <bryan@dady.us>
Signed-off-by: Bryan Dady <bryan@dady.us>
Signed-off-by: Bryan Dady <bryan@dady.us>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Bryan Dady <bryan@dady.us>
@bcdady bcdady merged commit f03f02c into main Dec 26, 2024
7 checks passed
@bcdady bcdady deleted the hugging-face branch December 26, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant