-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed watermask operator and used the classifier directly #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marpet
added a commit
that referenced
this pull request
Jul 22, 2021
* using TreeMap should give better performance, because the map entries are requested multiple times * disabled computation of not used result * constant array access moved before loop or if condition * replaced HashMaps by TreeMaps * constant array access moved before loop * removed unnecessary condition * removed watermask operator and used the classifier directly (#2) * removed watermask operator and used the classifier directly * inlined watermask also for OLCI and improved S2 * increased version to 7.0.1-SNAPSHOT * Idepix OLCI Cloud shadow fronts: do not change sourceFlagTile any more * some adjustments in Idepix MODIS * cleanup and a fix: for most sensors, cloud buffer was not correctly set if corresponding cloudy pixel was inside cloud buffer width, but outside tile boundary. Implementation was correct only for MERIS, S2MSI. * fix in S2IdepixOp: demName was not passed into post processing operator * added user option for a C3S-Lot5 processing mode in Idepix for ProbaV and SPOT-VGT * increased versions of Idepix Core, ProbaV and SPOT-VGT to 7.0.1-SNAPSHOT as they were recently changed * fixed distribution management * removed idepix dependencies and increased version * set to snapshot * set to snapshot * set to snapshot * set to snapshot * updated parent * set to snapshot * updated parent * updated parent * set to snapshot * updated parent * set to snapshot * remove file from index * fix cloud buffer tile boundary problem in ProbaV and VGT post processing * only remove bands that are contained in product * only remove reflectance bands for cloud shadow when compute cloud shadow is selected * fix in S2 MSI: user option 'computeCloudBufferForCloudAmbiguous' was ignored * fix in S2 MSI: latitude was not passed into S2 algorithm, thus snow test was not working * use geocoding to get lat value * S2 MSI: set version to 7.0.1 for release after latest fixes of snow flagging issues * S2 MSI: set version to 7.0.1 for release after latest fixes of snow flagging issues * corrected version in S2MSI Idepix * set version to 7.0.1 in OLCI * updated versions ins assembly pom * removed workspace file from project * removed .idea * Update README.md * increased versions of Idepix OLCI and Idepix core to 7.0.2-SNAPSHOT * Cloud shadow fixed for southern hemisphere * Flag of inland water is used to switch to the correct classification branch. * Comment removed for FRESH_INLAND_WATER flag. * fixed wrong parent pom in Idepix assembly pom * OLCI version 3.0.2 * idepix.core and olci set to module version 7.0.2; used in assembly * Idepix OLCI: fixed issue with snow/ice flag over fresh inland water * increased idepix-olci version to 7.0.3-SNAPSHOT * added preliminary changelog for olci * added travis configuration * removed old nexus repository * set guava ersion to 24.1.1-jre * set surefire version * using oracle jdk * switched to trusty dist- this one shall contain oracle jdk 8 * disabled travis * disabled travis * fixed NPE in OLCI postprocessing in case cloud buffer is disabled in user options * updated to SNAP 8 SNAPSHOT using single License.txt * testing travis with snap8 * trigger build * correctly named travis file * added travis badge to readme * Updated name of plugin category * updated gitignore * Bump junit from 4.12 to 4.13.1 (#19) Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](junit-team/junit4@r4.12...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * prepared IDEPIX 8.0 release * S2IdepixAlgorithm: removed isLand() condition in isClearSnow() method * Idepix S2: set version to 8.0.1-SNAPSHOT * Idepix S2: fix of performance issue * Idepix S2: eliminated wrong mountain shadows caused by not excluding elevation no-data value -32768 * added comment about the source of the algorithm * release S2MSI v8.0.1 * increased version to 8.0.2-SNAPSHOT * s2idepix-27-only-use-hillshade-mountain-shadow (#31) * fix cloud buffer tile boundary problem in ProbaV and VGT post processing * release S2MSI v8.0.2 * release S2MSI v8.0.2 * set S2MSI v8.0.3-SNAPSHOT * Idepix OLCI: made hillshade algorithm available (issue #28); some cleanup in all poms * Adapt Idepix OLCI to updated OLCI O2A Harmonisation #13 - increased dependency to 8.0.2 Found also issues in other dependencies. Now all modules got updated and have SNAPSHOT status. removed enivsat dependency from core module. * master is now at 9.0.0-SNAPSHOT and uses SNAP 9-SNAPSHOT maintenance is on the branch 8.x * Idepix MERIS: 4th reprocessing: uses adapter and Op now from s3tbx-sentinel3-reader module; fixed issue with valid pixel expression in radiance bands * creating also a lcuster. to be used in dev environment * changed name * fix #26 - Duplicated cloud shadow near scene edge in OLCI data * update help and exception message regarding TensorFlow and MS C++ redistributable * removed system.out.println * fix #14 Update Tensorflow library to latest version - it is now 1.15 * reverted #14 Update Tensorflow library to latest version * fix #14 Update Tensorflow library to latest version (again) * updated MERIS "Algorithm Specification" help page * idepix44: S2 Idepix ends with ArrayIndexOutOfBoundsException * idepix43: S2 Idepix creates very large log * use median if geometry center is not available * do not log as often * added import * added import * idepix-37: Update jblas library to 1.2.5 * idepix-30: clear water flags mountains as water * revert commit * fixed #26 Duplicated cloud shadow near scene edge in OLCI data * avoid arrayindexoutofboundsexception * fixes #46 - harmonised Pre-Processing to Preprocessing and set category to "Optical/Preprocessing/Masking" in Operator metadata * fixes #7 - Use style of SNAP 8/9 for help pages * removed guava dependency - not necessary * using TreeMap should give better performance, because the map entries are requested multiple times * disabled computation of not used result * constant array access moved before loop or if condition * replaced HashMaps by TreeMaps * constant array access moved before loop * removed unnecessary condition * not using TreeMap, because test needs HashMap (see comments) Co-authored-by: Olaf Danne <olaf.danne@brockmann-consult.de> Co-authored-by: Tonio Fincke <tonio.fincke@brockmann-consult.de> Co-authored-by: dagmarM <Dagmar.Mueller@brockmann-consult.de> Co-authored-by: Brockmann Consult Development <dev@brockmann-consult.de> Co-authored-by: dolaf <olaf.danne@> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the operator and use the classifier directly. But haven't really tested yet.
@dolaf Maybe you can try it?
This would be the first operator removed from the op-chain.