Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RuneQuest:Roleplaying in Glorantha] 成功段階の文言を日本語版に合わせて変更 #758

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FredGreenfield
Copy link
Contributor

@FredGreenfield FredGreenfield commented Jan 4, 2025

【背景】
当ダイスボットでは、Critical Successと Special Success をこれまでクリティカル、スペシャルとしていたが、ルーンクエスト ロールプレイング イン グローランサ の 日本語版スタートセットでは決定的成功、効果的成功と訳されている。

【修正】
上記の訳語に合わせるために Critical Success を決定的成功と Special Success を効果的成功へと変更を行った。
また、この修正に伴い、コメント、ヘルプ、テストケースの文言も修正した。

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (5d33c39) to head (6437d3c).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
+ Coverage   95.84%   95.88%   +0.03%     
==========================================
  Files         363      369       +6     
  Lines       21402    21626     +224     
  Branches     5617     5684      +67     
==========================================
+ Hits        20513    20736     +223     
- Misses        889      890       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FredGreenfield FredGreenfield changed the title 成功段階の文言を日本語版に合わせて変更 [RuneQuest:Roleplaying in Glorantha] 成功段階の文言を日本語版に合わせて変更 Jan 4, 2025
@FredGreenfield FredGreenfield reopened this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant