changed ML-DSA/SLH-DSA Jca signatures to return null if default 0 len…

…gth context is used, relates to github #1946.
bcgit · Dec 22, 2024 · d3f5333 · d3f5333
1 parent 185cf12
commit d3f5333
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.../org/bouncycastle/jcajce/provider/asymmetric/util/BaseDeterministicOrRandomSignature.java b/.../org/bouncycastle/jcajce/provider/asymmetric/util/BaseDeterministicOrRandomSignature.java
@@ -162,7 +162,7 @@ protected final AlgorithmParameters engineGetParameters()
     {
         if (engineParams == null)
         {
-            if (paramSpec != null)
+            if (paramSpec != null && paramSpec != ContextParameterSpec.EMPTY_CONTEXT_SPEC)
             {
                 try
                 {

diff --git a/prov/src/test/java/org/bouncycastle/pqc/jcajce/provider/test/MLDSATest.java b/prov/src/test/java/org/bouncycastle/pqc/jcajce/provider/test/MLDSATest.java
@@ -531,10 +531,8 @@ public void testHashMLDSAKATSig()
         assertTrue(sig.verify(genS));
 
         AlgorithmParameters algP = sig.getParameters();
-
-        ContextParameterSpec cSpec = algP.getParameterSpec(ContextParameterSpec.class);
-
-        assertTrue(Arrays.areEqual(new byte[0], cSpec.getContext()));
+
+        assertTrue(null == algP);
 
         // test using ml-dsa-44 for the key, should be the same.
-Original file line number
+Diff line change
@@ Expand Up / @@ -162,7 +162,7 @@ protected final AlgorithmParameters engineGetParameters() @@
         {
             if (engineParams == null)
             {
-                if (paramSpec != null)
+                if (paramSpec != null && paramSpec != ContextParameterSpec.EMPTY_CONTEXT_SPEC)
                 {
                     try
                     {
@@ Expand Down @@