Improve test coverage of PGP (v6) keys #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitasvitae
force-pushed
the
moreKeyTests
branch
5 times, most recently
from
475f0de
to
4847285
Compare
|
Oops, I noticed that during a previous rebase I got some unrelated commits included in the patch. |
vanitasvitae
force-pushed
the
moreKeyTests
branch
from
4847285
to
d626f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
PGPv6KeyTestto more extensively cover parsing of different fields, like key-id, creation time, s2k etc.Testing also showed, that
getBitStrength()returned0for (dedicated X25519), X448, Ed25519, Ed448 keys.It also returned
0for unknown keys.This PR fixes these issues by properly parsing the bit strength (as in key-size, not security-level).