-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High Level OpenPGP v6 Key Generation #1857
base: main
Are you sure you want to change the base?
Conversation
I'm contemplating whether to transform the There are some non-trivial differences between v4 and v6, most notably the fact that v6 stores preferences in a Direct-Key signature, while v4 prefers user-id certification signatures (at least if you want to be compatible to GnuPG). |
e7a3076
to
5b4cbed
Compare
5b4cbed
to
bb731e2
Compare
911179b
to
96f9e0e
Compare
Ready for review. Let me know if I can make your job easier by squashing or splitting this up into smaller PRs :) |
49b0dc4
to
c17f979
Compare
One thing I dislike about the current API design: An additional issue with the current API is, that I'm not sure, if there is a clean way to refactor the current API, circumsailing these rough edges in a backwards-compatible way. |
Hey!
In this PR, I'm working on a high-level API for OpenPGP key generation (v6 only for now).
Let me know, what you think of the design sketched out in
OpenPGPV6KeyGenerator
:)I tried to keep the API straight-forward, but still allow modifications of the (hashed) signature subpacket areas by the use of callbacks which the user can hook into, to modify the signature subpackets prior to signature generation.
The PR also adds key generator classes for individual keys, such that the risk of making mistakes during key generation (e.g. using wrong/weak parameters) is minimized.
I used PGPainless as orientation for the API design, but kept the generation API a bit slimmer for now. Let me know what you think of the direction the API is heading.