Skip to content

Fix assert statement in aesCbcEncrypt() and aesCbcDecrypt() #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

elliotwutingfeng
Copy link
Contributor

According to the documentation

The paddedPlainText must be a multiple of the block size
(128-bits).

However the assert statement assert(128 == paddedPlaintext.length * 8); checks if paddedPlaintext is exactly 128-bits long.

They should be switched to assert(0 == paddedPlaintext.length % 16); (16 bytes = 128 bits)

@Ephenodrom
Copy link
Contributor

@elliotwutingfeng
Hello, the PR was merged manually as this repository is a proxy. The fix will be available within the next version.
Thank you very much for your contribution.

@Ephenodrom Ephenodrom closed this Feb 12, 2025
@elliotwutingfeng elliotwutingfeng deleted the aescbc branch March 12, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants