Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix that would cause a crash due to event out student_not_found n… #10

Merged
merged 1 commit into from
Aug 22, 2023
Merged

bug fix that would cause a crash due to event out student_not_found n… #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...java/ca/bc/gov/educ/api/sld/notification/service/BaseStudentMergeEventHandlerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ private void processMergeTO(final StudentMerge studentMerge) throws BusinessExce


log.info("got response from STUDENT_API :: {}", responseEvent);
if (responseEvent.getEventOutcome() == EventOutcome.STUDENT_NOT_FOUND) {
if (responseEvent.getEventOutcome() == EventOutcome.STUDENTS_NOT_FOUND) {
log.error("Students not found or student size mismatch for student IDs:: {}, this should not have happened", studentIDs);
throw new BusinessException(BusinessError.STUDENT_NOT_FOUND);
}
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/ca/bc/gov/educ/api/sld/notification/struct/v1/EventOutcome.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public enum EventOutcome {
/**
* The Student not found.
*/
STUDENT_NOT_FOUND,
STUDENTS_NOT_FOUND,
/**
* Students found event outcome.
*/
Expand Down
Loading