test corrections.

bcgov · Aug 27, 2024 · 9449008 · 9449008
1 parent e2ea042
commit 9449008
Show file tree

Hide file tree

Showing 5 changed files with 266 additions and 37 deletions.
diff --git a/source/frontend/src/components/common/form/Select.tsx b/source/frontend/src/components/common/form/Select.tsx
@@ -101,11 +101,11 @@ export const Select: React.FC<React.PropsWithChildren<SelectProps>> = ({
 
   const renderPlaceholder = () => {
     const calculatedPlaceholder =
-      placeholder ?? options.find(option => option.value === value) ? null : 'N/A'; // Render N/A in the event that the currently selected value is not in the list.
-    if (!calculatedPlaceholder) {
+      !value || options.find(option => option.value === value) ? null : 'N/A'; // Render N/A in the event that the currently selected value is not in the list.
+    if (!calculatedPlaceholder && !placeholder) {
       return null;
     }
-    return <option value="">{`${calculatedPlaceholder}`}</option>;
+    return <option value="">{`${placeholder ?? calculatedPlaceholder}`}</option>;
   };
 
   const renderOptions = () => {

diff --git a/...tend/src/features/documents/documentDetail/__snapshots__/DocumentDetailForm.test.tsx.snap b/...tend/src/features/documents/documentDetail/__snapshots__/DocumentDetailForm.test.tsx.snap
@@ -362,6 +362,11 @@ exports[`DocumentDetailForm component > renders as expected 1`] = `
                     id="input-documentStatusCode"
                     name="documentStatusCode"
                   >
+                    <option
+                      value=""
+                    >
+                      N/A
+                    </option>
                     <option
                       class="option"
                       data-testid="select-option-NONE"

diff --git a/...ty/tabs/propertyDetails/update/__snapshots__/UpdatePropertyDetailsContainer.test.tsx.snap b/...ty/tabs/propertyDetails/update/__snapshots__/UpdatePropertyDetailsContainer.test.tsx.snap
@@ -677,6 +677,11 @@ exports[`UpdatePropertyDetailsContainer component > renders as expected 1`] = `
                   id="input-regionTypeCode"
                   name="regionTypeCode"
                 >
+                  <option
+                    value=""
+                  >
+                    N/A
+                  </option>
                   <option
                     class="option"
                     data-testid="select-option-1"
@@ -1416,6 +1421,11 @@ exports[`UpdatePropertyDetailsContainer component > renders as expected 1`] = `
                   id="input-pphStatusTypeCode"
                   name="pphStatusTypeCode"
                 >
+                  <option
+                    value=""
+                  >
+                    N/A
+                  </option>
                   <option
                     class="option"
                     data-testid="select-option-ARTERY"

diff --git a/...roperty/tabs/propertyDetails/update/__snapshots__/UpdatePropertyDetailsForm.test.tsx.snap b/...roperty/tabs/propertyDetails/update/__snapshots__/UpdatePropertyDetailsForm.test.tsx.snap
@@ -657,6 +657,11 @@ exports[`UpdatePropertyDetailsForm component > renders as expected 1`] = `
                 id="input-regionTypeCode"
                 name="regionTypeCode"
               >
+                <option
+                  value=""
+                >
+                  N/A
+                </option>
                 <option
                   class="option"
                   data-testid="select-option-1"
@@ -1396,6 +1401,11 @@ exports[`UpdatePropertyDetailsForm component > renders as expected 1`] = `
                 id="input-pphStatusTypeCode"
                 name="pphStatusTypeCode"
               >
+                <option
+                  value=""
+                >
+                  N/A
+                </option>
                 <option
                   class="option"
                   data-testid="select-option-ARTERY"