vitest fixes.

bcgov · Apr 29, 2024 · a64b0b3 · a64b0b3
1 parent 415021e
commit a64b0b3
Show file tree

Hide file tree

Showing 6 changed files with 345 additions and 11 deletions.
diff --git a/.github/workflows/app-react.yml b/.github/workflows/app-react.yml
@@ -52,7 +52,7 @@ jobs:
       - run: npm run build --if-present
         working-directory: ${{env.working-directory}}
 
-      - run: npm run coverage -- --maxWorkers=2
+      - run: npm run coverage -- --bail 1
         working-directory: ${{env.working-directory}}
         env:
           REACT_APP_TENANT: MOTI

diff --git a/source/frontend/package.json b/source/frontend/package.json
@@ -140,7 +140,7 @@
     "test": "tsc && vitest run",
     "test-u": "tsc && vitest run -u",
     "test:watch": "vitest watch",
-    "coverage": "vitest run --coverage --reporter=vitest-sonar-reporter",
+    "coverage": "vitest run --coverage",
     "update-snapshots": "vitest run -u",
     "eject": "react-scripts eject",
     "lint": "eslint src/ --ext .jsx,.js,.ts,.tsx --max-warnings 0",

diff --git a/source/frontend/src/features/contacts/list/ContactListView.test.tsx b/source/frontend/src/features/contacts/list/ContactListView.test.tsx
@@ -12,6 +12,7 @@ import {
   RenderOptions,
   waitFor,
   waitForElementToBeRemoved,
+  screen,
 } from '@/utils/test-utils';
 
 import { ContactListPage } from './ContactListPage';
@@ -75,10 +76,9 @@ describe('Contact List View', () => {
   });
 
   it('matches snapshot', async () => {
-    setupMockSearch();
-    const { asFragment, getByText } = setup();
-    await act(async () => {});
     setupMockSearch([defaultPersonSearchResult]);
+    const { asFragment } = setup();
+    await act(async () => {});
 
     const fragment = await waitFor(() => asFragment());
     expect(fragment).toMatchSnapshot();