Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-6031 ACQ file: Add Owner Representative #3210

Merged
merged 10 commits into from
Jun 1, 2023

Conversation

asanchezr
Copy link
Collaborator

file-details

file-update

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #3210 (8784b92) into dev (9a26c27) will increase coverage by 0.09%.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3210      +/-   ##
==========================================
+ Coverage   73.36%   73.46%   +0.09%     
==========================================
  Files        1260     1261       +1     
  Lines       28328    28388      +60     
  Branches     5059     5079      +20     
==========================================
+ Hits        20784    20856      +72     
+ Misses       7310     7298      -12     
  Partials      234      234              
Flag Coverage Δ
unittests 73.46% <93.93%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perties/map/acquisition/add/AddAcquisitionForm.tsx 60.65% <ø> (ø)
...quisition/update/summary/UpdateAcquisitionForm.tsx 80.39% <ø> (ø)
source/frontend/src/models/api/AcquisitionFile.ts 94.11% <ø> (ø)
.../features/properties/map/acquisition/add/models.ts 81.63% <66.66%> (-2.09%) ⬇️
...roperties/map/acquisition/update/summary/models.ts 90.19% <66.66%> (-3.14%) ⬇️
...els/Concepts/AcquisitionFile/AcquisitionFileMap.cs 100.00% <100.00%> (ø)
...itionFile/AcquisitionFileOwnerRepresentativeMap.cs 100.00% <100.00%> (ø)
...kend/dal/Repositories/AcquisitionFileRepository.cs 70.27% <100.00%> (+0.82%) ⬆️
...atures/properties/map/acquisition/common/models.ts 91.54% <100.00%> (+13.39%) ⬆️
...tion/detail/fileDetails/AcquisitionSummaryView.tsx 88.88% <100.00%> (+9.72%) ⬆️

... and 2 files with indirect coverage changes

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link
Collaborator

@devinleighsmith devinleighsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asanchezr please see my comment on the story regarding whether or not this should allow an organization to be selected for this field

@asanchezr
Copy link
Collaborator Author

@devinleighsmith see updated comments on the story. Owner Reps are always individuals

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit ff4043b into bcgov:dev Jun 1, 2023
@asanchezr asanchezr deleted the psp-6031-owner-rep branch June 1, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants