-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSP-6738 : Allow Contractor to Create Files #3407
Conversation
✅ No secrets were detected in the code. |
Codecov Report
@@ Coverage Diff @@
## dev #3407 +/- ##
==========================================
- Coverage 72.20% 72.15% -0.05%
==========================================
Files 1324 1326 +2
Lines 30813 30842 +29
Branches 5740 5744 +4
==========================================
+ Hits 22247 22254 +7
- Misses 8328 8348 +20
- Partials 238 240 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
return new JsonResult(_mapper.Map<AcquisitionFileModel>(acquisitionFile)); | ||
return new JsonResult(_mapper.Map<AcquisitionFileModel>(acquisitionFile)); | ||
} | ||
catch(BusinessRuleViolationException ex) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eddherrera this scares me a bit since normally business rule validation exceptions return a 400. I think this is a bit risky, as now other business rule violations within the service layer will get interpretated as a 409. Also the frontend will start displaying any response with a 409 in a toast where it may not be doing that currently.
Could we do something a bit safer here? maybe something like how the user override code gets returned from the backend?
`
else if (ex is UserOverrideException)
{
var exception = ex as UserOverrideException;
code = HttpStatusCode.Conflict;
message = exception.Message;
errorCode = (ex as UserOverrideException).UserOverride?.Code;
_logger.LogError(ex, "User override required to complete this action.");
}
`
or perhaps we just handle this issue on the frontend entirely? We should already know if a user is a contractor, should be easy to check if they are on the acq team of the file they are creating as well?
✅ No secrets were detected in the code. |
✅ No secrets were detected in the code. |
* PSP-6540 primary contacts for owner solicitor and interest holders (bcgov#3381) * Rename H120 specific interest holder model * Use generic model for generate interest holder * PSP-6540 Update generate forms for organization primary contacts * Test corrections * CI: Bump version to v4.0.0-59.25 * psp-6616 correct grouping logic/display of interest holders. (bcgov#3364) * CI: Bump version to v4.0.0-59.26 * remove redundant tag step, ensure that tag targets correct source tag. (bcgov#3375) Co-authored-by: Smith <Devin.Smith@quartech.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v4.0.0-59.27 * CI: Bump version to v4.0.0-59.28 * psp-3242: add plan number search for map and list views (bcgov#3344) * CI: Bump version to v4.0.0-59.29 * PSP-6642 - Comp Req Draft to Final Message should appear on save (bcgov#3382) Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v4.0.0-59.30 * bump word-wrap dep (bcgov#3383) * CI: Bump version to v4.0.0-59.31 * ensure contact address/email populated in tenant screen. (bcgov#3378) * ensure contact address/email populated in tenant screen. * test corrections. * CI: Bump version to v4.0.0-59.32 * Fix dependency override for deprecated library (bcgov#3384) * CI: Bump version to v4.0.0-59.33 * CI: Bump version to v4.0.0-59.34 * Bump DEV version - IS60 (bcgov#3386) * CI: Bump version to v4.0.0-60.1 * IS-60.00 Database Schema PSP_PIMS S60.00 Sprint 60 2023-Aug-03 - Added tables: - PIMS_COMP_REQ_FINANCIAL - PIMS_COMP_REQ_FINANCIAL_HIST - PIMS_EXPROP_PMT_PMT_ITEM - PIMS_EXPROP_PMT_PMT_ITEM_HIST - PIMS_EXPROPRIATION_PAYMENT - PIMS_EXPROPRIATION_PAYMENT_HIST - Altered tables: - PIMS_ACQUISITION_FILE - PIMS_ACQUISITION_FILE_HIST - PIMS_COMPENSATION_REQUISITION - PIMS_COMPENSATION_REQUISITION_HIST - PIMS_PROP_INTHLDR_INTEREST_TYPE - Dropped tables: - PIMS_ACQUISITION_PAYEE - PIMS_ACQUISITION_PAYEE_HIST - PIMS_COMP_REQ_H120 - PIMS_COMP_REQ_H120_HIST - PIMS_FORM_8 - PIMS_FORM_8_HIST - PIMS_PROPERTY_ADJACENT_LAND_TYPE - PIMS_PROP_PROP_ADJACENT_LAND_TYPE - Added test scripts: - 43_PIMS_ACQUISITION_FILE.sql - 44_PIMS_ACQUISITION_OWNER.sql - 45_INTEREST_HOLDER.sql - 47_PIMS_PERSON.sql - 48_PIMS_COMPENSATION_REQUISITION.sql - Requires additional metadata to meet standards * Updated Schema Image * Updated Build, Alter Up, and Test Data * Removed Files and Renamed * CI: Bump version to v4.0.0-60.2 * Updated scaffold and fixed compilation issues * Fixed tests * CI: Bump version to v4.0.0-60.3 * Alter Down for Adjacent Land Added * PSP-6659 When creating a file or project after certain time, the created stamp date is a day after (bcgov#3391) * Move date related util functions to separate file * Add tests for date util functions * PSP-6659 Refactor date formatting functions to assume the date was recorded in UTC * Fix imports * Update snapshots * Fix typo * Update snapshots * Logic fix * Fix faulty logic * Test corrections * Ensure date tests run OK on GMT timezone for GHA runners * Update mock property test dates * Fix double date encoding/formatting * Rename UTC date formatting function. Update jsdoc * CI: Bump version to v4.0.0-60.4 * PSP-6561 : Add "Final Date" to Compensation Requisition Input (bcgov#3394) Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v4.0.0-60.5 * Added Lease filters and anomalies to advanced property * Add Test Scripts and Seed for Adjacent Land in Build * Changed Script to Remove Temp File on Alter Down 999_DML_Migrate_ADJACENT_LAND_Data_From_TMP.sql * Added Temp Table Build and Test Data * psp 6602: replace agreement date with final on comp req list view * Refinement of Adjacent Land Temp Table and Test Data * CI: Bump version to v4.0.0-60.6 * Fixed payee functionality (bcgov#3396) Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v4.0.0-60.7 * psp-6674 fix lease log issues. (bcgov#3390) * CI: Bump version to v4.0.0-60.8 * Automation branch (bcgov#3388) * Digital Documents refactoring * Research File uncomment steps * Digital Documents refactoring * Research File uncomment steps * Refactoring on Wait() method * Refactoring on Wait() method --------- Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> * CI: Bump version to v4.0.0-60.9 * psp-6577: remove second modal upon cancel changes for acquisition file (bcgov#3380) * CI: Bump version to v4.0.0-60.10 * psp-6685: fix default country selection logic (bcgov#3400) Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> * CI: Bump version to v4.0.0-60.11 * regen scaffold * removed commented out code * CI: Bump version to v4.0.0-60.12 * CI: Bump version to v4.0.0-60.13 * psp-6664: remove primary contact column from non-interest payees view * CI: Bump version to v4.0.0-60.14 * CI: Bump version to v4.0.0-60.15 * PSP-6665 legacy payees (bcgov#3409) * Code cleanup * Modify compensation requisition update form for legacy payees * Don't let the frontend override the legacy payee - this is only intended to be populated via ETL * Update snapshots * Remove duplicate code. Fix references. * Support legacy payees in generated H-120 form * Populate payee information for H120 generation * Test corrections * CI: Bump version to v4.0.0-60.16 * PSP-6738 : Allow Contractor to Create Files (bcgov#3407) * PSP-6738 : Allow Contractor to Create Files * - switch exception to a custom one --------- Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v4.0.0-60.17 * PSP-5718 : Add view update remove form 8 expropriation (bcgov#3402) * PSP-5718 : Add view update remove form 8 expropriation - Scaffolding for componennts and models * - unit test scaffold * - fix typo * PSP-5718 - update - delete methods * - test updates * - tests fixes * - test fixes * - bug fixes and updates * - bug fixes and moved delete to container. * - fixes * - test update * - fix contact validation * - validate that only one payment item is added in the form8 --------- Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> * CI: Bump version to v4.0.0-60.18 * CI: Bump version to v4.0.0-60.19 * CI: Bump version to v4.0.0-60.20 * psp-6661: add primary contact for owner solictor on create acquisition screen * CI: Bump version to v4.0.0-60.21 * psp-6700: correct tooltip for edit property details btn * CI: Bump version to v4.0.0-60.22 * psp-6543: add missing fields error for acquisition file screens (bcgov#3392) * CI: Bump version to v4.0.0-60.23 * PSP-6742 : FT:Acquisition File: Compensation: User is not able to delete the draft status Requisition (bcgov#3411) Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v4.0.0-60.24 * PSP-6741 FT:Acquisition File: Compensation: Wrong date is displayed for the Final date and Agreement Date if the status of the requisition is final (bcgov#3414) * Create additional date formatting function for UTC dates * PSP-6741 Fix formatting of UTC dates * Fix date formatting for local dates * Update snapshots * CI: Bump version to v4.0.0-60.25 * Fixed interest holder being updated on the front end (bcgov#3413) * CI: Bump version to v4.0.0-60.26 * psp-6749: fix description display for form 8 (bcgov#3415) * CI: Bump version to v4.0.0-60.27 * Fixed null referencing (bcgov#3417) * CI: Bump version to v4.0.0-60.28 * PSP-6762 : FT:Acquisition File: Compensation: In the Edit screen compensation existing Payee field data is getting cleared (bcgov#3418) Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v4.0.0-60.29 * psp-6746: force exact match for calls to BC assessment (bcgov#3416) * CI: Bump version to v4.0.0-60.30 * PSP-6475 : Generate Expropriation Form - Form 8 (bcgov#3410) Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v4.0.0-60.31 * PSP-6630: ACQ files: Legacy Interest Holders section (bcgov#3420) Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v4.0.0-60.32 * psp-6748: fix app error when deleting a term * CI: Bump version to v4.0.0-60.33 * psp-6773: remove second confirmation modal for cancelling changes (bcgov#3421) * CI: Bump version to v4.0.0-60.34 * Fixed map interactions on edit property (bcgov#3423) * CI: Bump version to v4.0.0-60.35 * psp-6617 acquisition etl corrections, enhancements. (bcgov#3408) * CI: Bump version to v4.0.0-60.36 * CI: Bump version to v4.0.0-60.37 * s60 Fix | Updated Seed Scripts (bcgov#3427) * Updated Seed and Conversion Scripts * Updated XL8 Fix * Spelling fix for PIMS_PROPERTY_TENURE_TYPE * CI: Bump version to v4.0.0-60.38 * CI: Bump version to v4.0.0-60.39 * Update version.yml (bcgov#3429) remove automatic version bump in test * CI: Bump version to v4.0.0-60.40 * Activity cleanup (bcgov#3426) * Removed activity related code * Fixed tests * CI: Bump version to v4.0.0-60.41 * Test alter down fix (bcgov#3431) * Removed 032_DML_PIMS_PROPERTY_TENURE_TYPE_Alter_Down.sql * Deleted Tenure Type Alter Down * CI: Bump version to v4.0.0-60.39 * Automation: Calibrating Implicit waits and adding explicit waits where necessary (bcgov#3419) * Digital Documents refactoring * Research File uncomment steps * Digital Documents refactoring * Research File uncomment steps * Refactoring on Wait() method * Refactoring on Wait() method * Calibrating previous Waits refactoring for all test cases to run successfully * Calibrating previous Waits refactoring for all test cases to run successfully --------- Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> * CI: Bump version to v4.0.0-60.42 * IS-61 Database Schema (bcgov#3406) * IS-61 Database Schema PSP_PIMS S61.00 Sprint 60 2023-Aug-11 - Added tables: - TMP_PIMS_PROP_PROP_ADJACENT_LAND_TYPE - Altered tables: - PIMS_ACQUISITION_FILE - PIMS_ACQUISITION_FILE_HIST - PIMS_COMPENSATION_REQUISITION - PIMS_COMPENSATION_REQUISITION_HIST - Requires additional metadata to meet standards * Updated Property Tenure Build Script * Added Alters for PIMS_PROPERTY_TENURE_TYPE - 032_DML_PIMS_PROPERTY_TENURE_TYPE_Alter_Down.sql - 032_DML_PIMS_PROPERTY_TENURE_TYPE_Alter_Up.sql * Removed Scripts that were moved to IS-60 * Repaired 133_TMP_PIMS_PROP_PROP_ADJACENT_LAND_TYPE.sql * Dropped 133_TMP_PIMS_PROP_PROP_ADJACENT_LAND_TYPE.sql from Build --------- Co-authored-by: Manuel Rodriguez <marobej@gmail.com> * CI: Bump version to v4.0.0-60.43 * CI: Bump version to v4.0.0-60.44 * Psp 6580 initiate filter screen for project exports (bcgov#3432) * psp-6580 partial project export functionality - frontend filter logic only. * lint fixes. * remove duplicate test. * CI: Bump version to v4.0.0-60.45 * Generated scaffold from s61 (bcgov#3436) * CI: Bump version to v4.0.0-60.46 * PSP-6737 : FT-REG: Lease & Licenses - new date field looks misaligned on Deposit Returns modal (bcgov#3437) Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v4.0.0-60.40 * Updated PIMS PDM S61.00.png (bcgov#3438) * IS-61 Database Schema PSP_PIMS S61.00 Sprint 60 2023-Aug-11 - Added tables: - TMP_PIMS_PROP_PROP_ADJACENT_LAND_TYPE - Altered tables: - PIMS_ACQUISITION_FILE - PIMS_ACQUISITION_FILE_HIST - PIMS_COMPENSATION_REQUISITION - PIMS_COMPENSATION_REQUISITION_HIST - Requires additional metadata to meet standards * Updated Property Tenure Build Script * Added Alters for PIMS_PROPERTY_TENURE_TYPE - 032_DML_PIMS_PROPERTY_TENURE_TYPE_Alter_Down.sql - 032_DML_PIMS_PROPERTY_TENURE_TYPE_Alter_Up.sql * Removed Scripts that were moved to IS-60 * Repaired 133_TMP_PIMS_PROP_PROP_ADJACENT_LAND_TYPE.sql * Dropped 133_TMP_PIMS_PROP_PROP_ADJACENT_LAND_TYPE.sql from Build * Updated PIMS PDM S61.00.png Correct depiction of alternate project --------- Co-authored-by: Manuel Rodriguez <marobej@gmail.com> * CI: Bump version to v4.0.0-60.47 * Added tenure filters | psp-4804 (bcgov#3430) * Added tenure filters * Fixed typos * CI: Bump version to v4.0.0-60.48 * Psp-6518 agreements export. (bcgov#3440) * psp-6518 Agreement export. * lint corrections. * test correction. * CI: Bump version to v4.0.0-60.49 * psp-6820 make take area optional (bcgov#3444) * CI: Bump version to v4.0.0-60.41 * restoring updated version of PIMS_USER seed script, overriden in IS60. (bcgov#3446) * CI: Bump version to v4.0.0-60.50 * psp-6803 ensure that nip/ip interests are separated correctly. (bcgov#3445) * psp-6803 ensure that nip/ip interests are separated correctly. * PR correction from code review. * deposit null vs undefined fix * CI: Bump version to v4.0.0-60.42 * psp-6784: fix missing fields required message displays (bcgov#3424) * CI: Bump version to v4.0.0-60.43 * Fix agriculture flag not workling | psp-6759 (bcgov#3447) * Updated layer url * Updated tests * IS-60.01 Update (bcgov#3443) * Updated 079_DML_PIMS_PROPERTY_ROAD_TYPE_* - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Up.sql - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Down.sql * Reset * IS-60.01 Database Schema - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Up.sql - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Down.sql * Update Adjacent Land XLN and DB versions * Updated 999_DML_Migrate_ADJACENT_LAND_Data_From_TMP.sql * Updated Migrate_ADJACENT_LAND_Data Scripts * CI: Bump version to v4.0.0-60.44 * bump dev version (bcgov#3448) * CI: Bump version to v4.0.0-61.51 * Updated 999_DML_Migrate_ADJACENT_LAND_Data_From_TMP.sql (bcgov#3451) * Updated 079_DML_PIMS_PROPERTY_ROAD_TYPE_* - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Up.sql - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Down.sql * Reset * IS-60.01 Database Schema - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Up.sql - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Down.sql * Update Adjacent Land XLN and DB versions * Updated 999_DML_Migrate_ADJACENT_LAND_Data_From_TMP.sql * Updated Migrate_ADJACENT_LAND_Data Scripts * Updated 999_DML_Migrate_ADJACENT_LAND_Data_From_TMP.sql -Alter Up/999_DML_Migrate_ADJACENT_LAND_Data_From_TMP.sql * CI: Bump version to v4.0.0-60.45 * Fixed property not displaying correctly on the map (bcgov#3452) * CI: Bump version to v4.0.0-60.46 * merge corrections. * Backmerge test to dev (bcgov#3453) * PSP-6737 : FT-REG: Lease & Licenses - new date field looks misaligned on Deposit Returns modal (bcgov#3437) Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v4.0.0-60.40 * psp-6820 make take area optional (bcgov#3444) * CI: Bump version to v4.0.0-60.41 * psp-6803 ensure that nip/ip interests are separated correctly. (bcgov#3445) * psp-6803 ensure that nip/ip interests are separated correctly. * PR correction from code review. * deposit null vs undefined fix * CI: Bump version to v4.0.0-60.42 * psp-6784: fix missing fields required message displays (bcgov#3424) * CI: Bump version to v4.0.0-60.43 * IS-60.01 Update (bcgov#3443) * Updated 079_DML_PIMS_PROPERTY_ROAD_TYPE_* - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Up.sql - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Down.sql * Reset * IS-60.01 Database Schema - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Up.sql - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Down.sql * Update Adjacent Land XLN and DB versions * Updated 999_DML_Migrate_ADJACENT_LAND_Data_From_TMP.sql * Updated Migrate_ADJACENT_LAND_Data Scripts * CI: Bump version to v4.0.0-60.44 * Updated 999_DML_Migrate_ADJACENT_LAND_Data_From_TMP.sql (bcgov#3451) * Updated 079_DML_PIMS_PROPERTY_ROAD_TYPE_* - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Up.sql - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Down.sql * Reset * IS-60.01 Database Schema - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Up.sql - 079_DML_PIMS_PROPERTY_ROAD_TYPE_Alter_Down.sql * Update Adjacent Land XLN and DB versions * Updated 999_DML_Migrate_ADJACENT_LAND_Data_From_TMP.sql * Updated Migrate_ADJACENT_LAND_Data Scripts * Updated 999_DML_Migrate_ADJACENT_LAND_Data_From_TMP.sql -Alter Up/999_DML_Migrate_ADJACENT_LAND_Data_From_TMP.sql * CI: Bump version to v4.0.0-60.45 * merge corrections. --------- Co-authored-by: Eduardo <eddherrera@users.noreply.github.com> Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Aman Monga <53246811+buddy326@users.noreply.github.com> Co-authored-by: Doug Filteau <dfilteau@users.noreply.github.com> * CI: Bump version to v4.0.0-61.52 * 4.0 acquisition, codes and pims etl corrections. (bcgov#3449) ensure comp req codes are mapped correctly ensure that '55' is respected uniformly on code values interest holders and subtables now mapped pims land parcels all imported now owner reps and solicitors corrected. * CI: Bump version to v4.0.0-60.47 * correct merge markers. * CI: Bump version to v4.0.0-61.53 * Bump DEV version - IS62 (bcgov#3458) * CI: Bump version to v4.0.0-62.1 * correct take, payee, property address, region logic. (bcgov#3459) * CI: Bump version to v4.0.0-60.48 * Made types immutable (bcgov#3460) * CI: Bump version to v4.0.0-60.49 * correct issue with lease payments not calculating gst. (bcgov#3462) * CI: Bump version to v4.0.0-60.50 * Fixed form8 navigation | psp-6866 (bcgov#3463) * Fixed form8 navigation * fixed test * CI: Bump version to v4.0.0-60.51 * Backmerge test to dev (bcgov#3465) * Fixed property not displaying correctly on the map (bcgov#3452) * CI: Bump version to v4.0.0-60.46 * 4.0 acquisition, codes and pims etl corrections. (bcgov#3449) ensure comp req codes are mapped correctly ensure that '55' is respected uniformly on code values interest holders and subtables now mapped pims land parcels all imported now owner reps and solicitors corrected. * CI: Bump version to v4.0.0-60.47 * correct take, payee, property address, region logic. (bcgov#3459) * CI: Bump version to v4.0.0-60.48 * Made types immutable (bcgov#3460) * CI: Bump version to v4.0.0-60.49 * correct issue with lease payments not calculating gst. (bcgov#3462) * CI: Bump version to v4.0.0-60.50 * Fixed form8 navigation | psp-6866 (bcgov#3463) * Fixed form8 navigation * fixed test * CI: Bump version to v4.0.0-60.51 --------- Co-authored-by: Manuel Rodriguez <marobej@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Smith <Devin.Smith@quartech.com> * CI: Bump version to v4.0.0-62.2 * add gha to retag test to uat. * CI: Bump version to v4.0.0-62.3 * PSP-6732 Add tooltip for alternate project (bcgov#3464) * CI: Bump version to v4.0.0-62.4 * PIMS Automation - Acquisition File refactoring and Adding Checklists, Agreements and Stakeholders (bcgov#3461) * Digital Documents refactoring * Research File uncomment steps * Digital Documents refactoring * Research File uncomment steps * Refactoring on Wait() method * Refactoring on Wait() method * Calibrating previous Waits refactoring for all test cases to run successfully * Calibrating previous Waits refactoring for all test cases to run successfully * Acquisition File - Checklist * Acquisition File refactoring and Stakeholders * Acquisition Files Stakeholders --------- Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> * CI: Bump version to v4.0.0-62.5 * PSP-6517 Compensation Requisition Export (bcgov#3455) * Merge existing work from other PR * Initial commit for H120 transaction report * Rename controller method * PSP-6517 Compensation Financials Report * Connect frontend with backend endpoints * Fix typing * Lint fixes * Calculate aggregate totals by project * API will return status 204 to signal that we did not find any matching records. * Lint fix * Expose axios response status via useApiRequestWrapper hook * Show warning when no records were found to export * Order export results as per Confluence rules * Fix date formatting issue * Test updates * Backend test updates * Lint fixes * Backend service tests * Backend repository tests * PR feedback * Change date format as per BA comments * Fix unit tests * CI: Bump version to v4.0.0-62.6 * PSP-6494 : Acquisition List View Export (Excel) (bcgov#3441) Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v4.0.0-62.7 * psp-6610: add alternate project field for comp reqs (bcgov#3439) * CI: Bump version to v4.0.0-62.8 * add support for '55' RC codes. (bcgov#3467) * CI: Bump version to v4.0.0-62.9 * IS-62.00 Database Schema (bcgov#3470) * IS-61 Database Schema PSP_PIMS S61.00 Sprint 60 2023-Aug-11 - Added tables: - TMP_PIMS_PROP_PROP_ADJACENT_LAND_TYPE - Altered tables: - PIMS_ACQUISITION_FILE - PIMS_ACQUISITION_FILE_HIST - PIMS_COMPENSATION_REQUISITION - PIMS_COMPENSATION_REQUISITION_HIST - Requires additional metadata to meet standards * Updated Property Tenure Build Script * Added Alters for PIMS_PROPERTY_TENURE_TYPE - 032_DML_PIMS_PROPERTY_TENURE_TYPE_Alter_Down.sql - 032_DML_PIMS_PROPERTY_TENURE_TYPE_Alter_Up.sql * Removed Scripts that were moved to IS-60 * Repaired 133_TMP_PIMS_PROP_PROP_ADJACENT_LAND_TYPE.sql * Dropped 133_TMP_PIMS_PROP_PROP_ADJACENT_LAND_TYPE.sql from Build * Updated PIMS PDM S61.00.png Correct depiction of alternate project * IS-62.00 Database Schema PSP_PIMS S62.00 Sprint 61 2023-Aug-29 - Dropped tables: - TMP_PIMS_PROP_PROP_ADJACENT_LAND_TYPE - Altered tables: - PIMS_INTEREST_HOLDER_HIST - Requires additional metadata to meet standards * Update PIMS S62.00 Change Log.txt Repair mis-merged file. * Updated roles and claims to align with alter ups * Removed activity claims and aligned latest --------- Co-authored-by: Doug Filteau <dfilteau@users.noreply.github.com> * CI: Bump version to v4.0.0-62.10 * Bump version to IS63 (bcgov#3478) * CI: Bump version to v4.0.0-63.1 * psp-6844 agreement corrections. (bcgov#3473) Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v4.0.0-63.2 * psp-6836 ensure boundary added when property location is added. (bcgov#3472) * CI: Bump version to v4.0.0-63.3 * psp-6856 correct display of address country - other field. (bcgov#3471) * psp-6856 correct display of address country - other field. * correct emptying of file related entities. * correct stakeholder spacing, yup schema. * introduce support for multi-polygons. * CI: Bump version to v4.0.0-63.4 * Automation FT Testing - Acquisition Files - Compensations, changes on Digital documents, contacts (bcgov#3477) * Digital Documents refactoring * Research File uncomment steps * Digital Documents refactoring * Research File uncomment steps * Refactoring on Wait() method * Refactoring on Wait() method * Calibrating previous Waits refactoring for all test cases to run successfully * Calibrating previous Waits refactoring for all test cases to run successfully * Acquisition File - Checklist * Acquisition File refactoring and Stakeholders * Acquisition Files Stakeholders * Acquisition Files - Compensation Requisition, Changing Digital Documents - Upload test documents * Testing queries update --------- Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v4.0.0-63.5 * PSP-6043 Fix frontend tests making web requests (bcgov#3476) * Configure MSW to throw an error for unhandled requests * Mock out repositories to prevent external web calls * Update snapshots * CI: Bump version to v4.0.0-63.6 * psp-6898 correct document list paging. (bcgov#3475) * CI: Bump version to v4.0.0-63.7 * FT Automation - Leases refactoring (bcgov#3480) * Digital Documents refactoring * Research File uncomment steps * Digital Documents refactoring * Research File uncomment steps * Refactoring on Wait() method * Refactoring on Wait() method * Calibrating previous Waits refactoring for all test cases to run successfully * Calibrating previous Waits refactoring for all test cases to run successfully * Acquisition File - Checklist * Acquisition File refactoring and Stakeholders * Acquisition Files Stakeholders * Acquisition Files - Compensation Requisition, Changing Digital Documents - Upload test documents * Testing queries update * Leases Refactoring --------- Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v4.0.0-63.8 * Added filter for team members and updated list view | psp-6151 (bcgov#3474) * Added filter for team members and updated list view * Addressed BAs sugestions * Added pr requests * CI: Bump version to v4.0.0-63.9 * PSP-6775 : Disallow Contractor to Remove Themself From File (bcgov#3479) * CI: Bump version to v4.0.0-63.10 * Features/psp 6825 (bcgov#3482) * Property contact front end * Fix snaps * PR requests * CI: Bump version to v4.0.0-63.11 * IS-63.00 Database Schema (bcgov#3483) * IS-63.00 Database Schema PSP_PIMS S63.00 Sprint 62 2023-Sep-14 - Altered tables: - PIMS_COMPENSATION_REQUISITION - PIMS_COMPENSATION_REQUISITION_HIST - PIMS_INTEREST_HOLDER - PIMS_PROPERTY - PIMS_PROPERTY_HIST - Added tables: - PIMS_PROP_PROP_CLASSIFICATION_HIST - PIMS_PROP_PROP_PURPOSE - PIMS_PROP_PROP_PURPOSE_HIST - PIMS_PROPERTY_ACTIVITY_HIST - PIMS_PROPERTY_CONTACT - PIMS_PROPERTY_CONTACT_HIST - PIMS_PROPERTY_PURPOSE_TYPE - Dropped tables: - PIMS_ACQUISITION_ACTIVITY_INSTANCE - PIMS_ACQUISITION_ACTIVITY_INSTANCE_HIST - PIMS_ACT_INST_PROP_ACQ_FILE - PIMS_ACT_INST_PROP_ACQ_FILE_HIST - PIMS_ACT_INST_PROP_RSRCH_FILE - PIMS_ACT_INST_PROP_RSRCH_FILE_HIST - PIMS_ACTIVITY_INSTANCE - PIMS_ACTIVITY_INSTANCE_HIST - PIMS_ACTIVITY_INSTANCE_DOCUMENT - PIMS_ACTIVITY_INSTANCE_DOCUMENT_HIST - PIMS_ACTIVITY_INSTANCE_NOTE_HIST - PIMS_ACTIVITY_INSTANCE_NOTE - PIMS_ACTIVITY_INSTANCE_STATUS_TYPE - PIMS_ACTIVITY_TEMPLATE - PIMS_ACTIVITY_TEMPLATE_HIST - PIMS_ACTIVITY_TEMPLATE_TYPE - PIMS_ACTIVITY_TEMPLATE_DOCUMENT - PIMS_ACTIVITY_TEMPLATE_DOCUMENT_HIST - PIMS_LEASE_ACTIVITY_INSTANCE - PIMS_LEASE_ACTIVITY_INSTANCE_HIST - PIMS_RESEARCH_ACTIVITY_INSTANCE - PIMS_RESEARCH_ACTIVITY_INSTANCE_HIST - Altered test scripts: - 005_DML_LEASE_PROPERTY.sql - Added test scripts: - 049_PIMS_PROP_PROP_PURPOSE.sql - Altered seed scripts: - 043_DML_PIMS_PROPERTY_CLASSIFICATION_TYPE.sql - 054_DML_PIMS_LEASE_LICENSE_TYPE.sql - 123_DML_PIMS_FORM_TYPE.sql - Added seed scripts: - 133_DML_PIMS_PROPERTY_PURPOSE_TYPE.sql - Dropped seed scripts: - 094_DML_PIMS_ACTIVITY_TEMPLATE_TYPE.sql - 097_DML_PIMS_ACTIVITY_INSTANCE_STATUS_TYPE.sql - 100_DML_PIMS_ACTIVITY_TEMPLATE.sql - Requires additional metadata to meet standards * Removed activity test files and aligned user and lease property test files --------- Co-authored-by: Manuel Rodriguez <marobej@gmail.com> * CI: Bump version to v4.0.0-63.12 * Scaffold/s63 (bcgov#3484) * IS-63.00 Database Schema PSP_PIMS S63.00 Sprint 62 2023-Sep-14 - Altered tables: - PIMS_COMPENSATION_REQUISITION - PIMS_COMPENSATION_REQUISITION_HIST - PIMS_INTEREST_HOLDER - PIMS_PROPERTY - PIMS_PROPERTY_HIST - Added tables: - PIMS_PROP_PROP_CLASSIFICATION_HIST - PIMS_PROP_PROP_PURPOSE - PIMS_PROP_PROP_PURPOSE_HIST - PIMS_PROPERTY_ACTIVITY_HIST - PIMS_PROPERTY_CONTACT - PIMS_PROPERTY_CONTACT_HIST - PIMS_PROPERTY_PURPOSE_TYPE - Dropped tables: - PIMS_ACQUISITION_ACTIVITY_INSTANCE - PIMS_ACQUISITION_ACTIVITY_INSTANCE_HIST - PIMS_ACT_INST_PROP_ACQ_FILE - PIMS_ACT_INST_PROP_ACQ_FILE_HIST - PIMS_ACT_INST_PROP_RSRCH_FILE - PIMS_ACT_INST_PROP_RSRCH_FILE_HIST - PIMS_ACTIVITY_INSTANCE - PIMS_ACTIVITY_INSTANCE_HIST - PIMS_ACTIVITY_INSTANCE_DOCUMENT - PIMS_ACTIVITY_INSTANCE_DOCUMENT_HIST - PIMS_ACTIVITY_INSTANCE_NOTE_HIST - PIMS_ACTIVITY_INSTANCE_NOTE - PIMS_ACTIVITY_INSTANCE_STATUS_TYPE - PIMS_ACTIVITY_TEMPLATE - PIMS_ACTIVITY_TEMPLATE_HIST - PIMS_ACTIVITY_TEMPLATE_TYPE - PIMS_ACTIVITY_TEMPLATE_DOCUMENT - PIMS_ACTIVITY_TEMPLATE_DOCUMENT_HIST - PIMS_LEASE_ACTIVITY_INSTANCE - PIMS_LEASE_ACTIVITY_INSTANCE_HIST - PIMS_RESEARCH_ACTIVITY_INSTANCE - PIMS_RESEARCH_ACTIVITY_INSTANCE_HIST - Altered test scripts: - 005_DML_LEASE_PROPERTY.sql - Added test scripts: - 049_PIMS_PROP_PROP_PURPOSE.sql - Altered seed scripts: - 043_DML_PIMS_PROPERTY_CLASSIFICATION_TYPE.sql - 054_DML_PIMS_LEASE_LICENSE_TYPE.sql - 123_DML_PIMS_FORM_TYPE.sql - Added seed scripts: - 133_DML_PIMS_PROPERTY_PURPOSE_TYPE.sql - Dropped seed scripts: - 094_DML_PIMS_ACTIVITY_TEMPLATE_TYPE.sql - 097_DML_PIMS_ACTIVITY_INSTANCE_STATUS_TYPE.sql - 100_DML_PIMS_ACTIVITY_TEMPLATE.sql - Requires additional metadata to meet standards * Generated scaffold and cleaned up remaining files * Manual merge * Manual merge --------- Co-authored-by: Doug Filteau <dfilteau@users.noreply.github.com> * CI: Bump version to v4.0.0-63.13 * psp-6906 management claims (bcgov#3485) Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> * CI: Bump version to v4.0.0-63.14 * Fix section headers (bcgov#3489) * CI: Bump version to v4.0.0-63.15 * PSP-6861 : Add "Advanced Payment Served Date" (bcgov#3486) * PSP-6861 : Add "Advanced Payment Served Date" * - linting --------- Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * PSP-6865 property management models (bcgov#3488) * Add new properties to backend models * Get property leases by property-id * API models and basic edit/view * Fix EF query * Update backend mappings * Model update * CI: Bump version to v4.0.0-63.16 * introduce keycloak to dev test ci/cd pipelines as the action appears stable. Will need alternate action for uat prod that runs in openshift. * integration test corrections. * add automated database deploy to dev cd/cd pipeline. * correct yaml --------- Co-authored-by: Sue Tairaku <42981334+stairaku@users.noreply.github.com> Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Smith <Devin.Smith@quartech.com> Co-authored-by: Aman Monga <53246811+buddy326@users.noreply.github.com> Co-authored-by: Eduardo <eddherrera@users.noreply.github.com> Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> Co-authored-by: Doug Filteau <dfilteau@users.noreply.github.com> Co-authored-by: Manuel Rodriguez <marobej@gmail.com> Co-authored-by: buddy326 <aman260@outlook.com>
No description provided.