Psp 7281 #3617
Psp 7281 #3617
Conversation
| .Map(dest => dest.DispositionFundingTypeCodeNavigation, src => src.FundingTypeCode) | ||
| .Map(dest => dest.DispositionFileStatusTypeCodeNavigation, src => src.FileStatusTypeCode) | ||
| .Map(dest => dest.DspPhysFileStatusTypeCodeNavigation, src => src.PhysicalFileStatusTypeCode) | ||
| .Map(dest => dest.DispositionTypeCodeNavigation, src => src.DispositionTypeCode) |
There was a problem hiding this comment.
just checking that we have a mapping that goes from model to the typecode navigation...
I think we usually set the string on the way in, not the navigation property itself
ie
.Map(dest => dest.DispositionTypeCode, src => src.DispositionTypeCode.Id)
...
|
|
||
| /* | ||
| * Frontend model | ||
| * LINK @frontend/src\models\api\DispositionFile.ts:14 |
There was a problem hiding this comment.
nit and question: are we forced to use a mix of forward slashes and backward slashes here or can we use forward slashes only?
There was a problem hiding this comment.
That would be a better question for @FuriousLlama, as currently he is the only one with this library functional. This conforms to the pattern that I've seen on other backend model files.
| .Map(dest => dest.TeamProfileType, src => src.DspFlTeamProfileTypeCodeNavigation) | ||
| .Map(dest => dest.TeamProfileTypeCode, src => src.DspFlTeamProfileTypeCode) |
There was a problem hiding this comment.
TeamProfile and TeamProfileTypeCode seems to be duplicated (one is the string code, the other the typemodel representation of it). Perhaps the string one could be removed?
| /// <summary> | ||
| /// get/set - The Team's profile type code. | ||
| /// </summary> | ||
| public string TeamProfileTypeCode { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// get/set - The Team's profile type code. | ||
| /// </summary> | ||
| public TypeModel<string> TeamProfileType { get; set; } |
There was a problem hiding this comment.
is there a need to keep the duplicate TeamProfileTypeCode in the model when we already have the TypeModel for it?
| .ThenInclude(d => d.PrimaryContact) | ||
| .Include(d => d.PimsDispositionFileTeams) | ||
| .ThenInclude(d => d.DspFlTeamProfileTypeCodeNavigation) | ||
| .FirstOrDefault(d => d.DispositionFileId == id); |
There was a problem hiding this comment.
want to confirm this follows existing patterns - I believe we throw a keynotfound exception if no entity is found by id?
| @@ -1,4 +1,5 @@ | |||
| using System.Collections.Generic; | |||
| using DocumentFormat.OpenXml.InkML; | |||
| <StyledFormWrapper> | ||
| {error && ( | ||
| <b> | ||
| Failed to load Diposition File. Check the detailed error in the top right for |
There was a problem hiding this comment.
nit: type "Diposition" -> Disposition
| teamProfileTypeCode?: string; | ||
| teamProfileType?: Api_TypeCode<string>; |
There was a problem hiding this comment.
like the backend models I think the type model is enough - no need to keep the string code as well
No description provided.