Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UAT Release IS-79 #4005

Merged
merged 55 commits into from
May 8, 2024
Merged

UAT Release IS-79 #4005

merged 55 commits into from
May 8, 2024

Conversation

asanchezr
Copy link
Collaborator

No description provided.

devinleighsmith and others added 30 commits April 26, 2024 10:02
* vitest - config and packages.

* vitest tests with trivial changes - no review required.

* non-test file changes - do not need review.

* snapshots - do not require review.

* These changes should be reviewed.

* merge corrections.

* test corrections.

* update coverage configuration

* coverage corrections.

* test changes

* re-enable tests.

---------

Co-authored-by: Smith <devin.smith@quartech.com>
Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com>
* IS-79.00 Database Schema

PSP_PIMS | Development Sprint: S79.00 | Design Sprint: 78 | Date: 2024-Apr-23
- Altered tables:
  - PIMS_ACQUISITION_FILE
  - PIMS_PROPERTY
- Added seed scripts:
  - 007_PSP_PIMS_ACQUISITION_FILE_HIST_Add.sql
  - 151_DML_PIMS_FILE_NUMBER_TYPE.sql
- Altered seed scripts:
  - 116_DML_PIMS_TAKE_TYPE.sql
- Altered test scripts:
  - 031_PIMS_ACQUISITION_FILE.sql
  - 033_PIMS_PROPERTY_ACQUISITION_FILE.sql
  - 043_PIMS_ACQUISITION_FILE.sql
  - 058_PIMS_TAKE.sql
- Added test scripts:
  - 075_PIMS_FILE_NUMBER.sql
- Requires additional metadata to meet standards

* Updated Lease Purpose Codes

Late addition to the release.

---------

Co-authored-by: Manuel Rodriguez <marobej@gmail.com>
* Generated scaffold

* Compilation fixes
…cgov#3976)

* Adding or improving list views and pagination

* Automation - changes based on Build updates

* Deleting unnecessary comments

* Subdivision/ Consolidation - Alternative testing paths

* Updates based on last deployment to TST environment

---------

Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com>
Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com>
* vitest fixes.

* re-install moment-timezone.

* remove only modifier

* snapshot update.

* skip failing test.

* vitest performance and mocking corrections.

* ensure console warnings are treated as failures.

* try skipping troublesome test.

* acquisition file owners.
Co-authored-by: Herrera <eduardo.herrera@quartech.com>
* psp-7909 take ui refactor.

* psp-8145

* correct invalid type.

* code review corrections.

* merge corrections.
* vitest fixes.

* re-install moment-timezone.

* vitest performance and mocking corrections.

* ensure console warnings are treated as failures.

* try skipping troublesome test.

* update msw, make some corrections to aid with test instability.

* increase maxworkers now that test stability increased.

* package updates.
* Code cleanup

* Show common area component on lease view

* Update property-lease repository to return area unit type-code

* Use common area component to update lease property areas

* Test updates

* Increase spacing as per UI/UX review

* Update snapshots
…gov#3986)

Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com>
…gov#3991)

* PSP-8366 : Enforce character limit on file names in document list

* - updates

---------

Co-authored-by: Herrera <eduardo.herrera@quartech.com>
github-actions bot and others added 20 commits May 3, 2024 23:35
Co-authored-by: Herrera <eduardo.herrera@quartech.com>
* IS-79.00 Property View Updates

* IS-79.00 Added PIMS_PROPERTY_VW View

---------

Co-authored-by: Manuel Rodriguez <marobej@gmail.com>
Correctly handle either comma or pipe delimeted pids.
Add error message for multiple pid responses.
…ated (bcgov#4002)

* Updated take calculation to use incoming take if being updated

* PR fixes
PIMS Property and Address Merge ETL
Copy link
Contributor

github-actions bot commented May 8, 2024

✅ No secrets were detected in the code.

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 87.76978% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 85.37%. Comparing base (bad6943) to head (81775aa).
Report is 1 commits behind head on test.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             test    #4005       +/-   ##
===========================================
+ Coverage   74.65%   85.37%   +10.71%     
===========================================
  Files        1443     1585      +142     
  Lines       40088   119668    +79580     
  Branches     8244     9181      +937     
===========================================
+ Hits        29929   102161    +72232     
- Misses       9860    17205     +7345     
- Partials      299      302        +3     
Flag Coverage Δ
unittests 85.37% <87.76%> (+10.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...kend/api/Areas/Takes/Controllers/TakeController.cs 100.00% <100.00%> (ø)
source/backend/api/Services/DocumentService.cs 96.77% <100.00%> (+0.16%) ⬆️
...rce/backend/api/Solvers/DispositionStatusSolver.cs 76.92% <ø> (ø)
...models/Models/Concepts/Property/PropertyViewMap.cs 100.00% <100.00%> (ø)
...ackend/dal/Repositories/PropertyLeaseRepository.cs 58.82% <100.00%> (+1.24%) ⬆️
source/backend/dal/Repositories/TakeRepository.cs 100.00% <100.00%> (+100.00%) ⬆️
source/frontend/src/App.tsx 0.00% <ø> (ø)
...end/api/Areas/Tools/Mappers/SitePidsResponseMap.cs 87.50% <0.00%> (ø)
...end/api/Services/CompensationRequisitionService.cs 95.87% <50.00%> (ø)
...rce/backend/dal/Repositories/PropertyRepository.cs 85.45% <66.66%> (+1.60%) ⬆️
... and 5 more

... and 1100 files with indirect coverage changes

@asanchezr asanchezr merged commit 8d94297 into bcgov:test May 8, 2024
9 checks passed
@asanchezr asanchezr deleted the uat_release_is79 branch May 10, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants