-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UAT Release IS-79 #4005
Merged
Merged
UAT Release IS-79 #4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* vitest - config and packages. * vitest tests with trivial changes - no review required. * non-test file changes - do not need review. * snapshots - do not require review. * These changes should be reviewed. * merge corrections. * test corrections. * update coverage configuration * coverage corrections. * test changes * re-enable tests. --------- Co-authored-by: Smith <devin.smith@quartech.com>
Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com>
* IS-79.00 Database Schema PSP_PIMS | Development Sprint: S79.00 | Design Sprint: 78 | Date: 2024-Apr-23 - Altered tables: - PIMS_ACQUISITION_FILE - PIMS_PROPERTY - Added seed scripts: - 007_PSP_PIMS_ACQUISITION_FILE_HIST_Add.sql - 151_DML_PIMS_FILE_NUMBER_TYPE.sql - Altered seed scripts: - 116_DML_PIMS_TAKE_TYPE.sql - Altered test scripts: - 031_PIMS_ACQUISITION_FILE.sql - 033_PIMS_PROPERTY_ACQUISITION_FILE.sql - 043_PIMS_ACQUISITION_FILE.sql - 058_PIMS_TAKE.sql - Added test scripts: - 075_PIMS_FILE_NUMBER.sql - Requires additional metadata to meet standards * Updated Lease Purpose Codes Late addition to the release. --------- Co-authored-by: Manuel Rodriguez <marobej@gmail.com>
* Generated scaffold * Compilation fixes
…cgov#3976) * Adding or improving list views and pagination * Automation - changes based on Build updates * Deleting unnecessary comments * Subdivision/ Consolidation - Alternative testing paths * Updates based on last deployment to TST environment --------- Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com> Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com>
* vitest fixes. * re-install moment-timezone. * remove only modifier * snapshot update. * skip failing test. * vitest performance and mocking corrections. * ensure console warnings are treated as failures. * try skipping troublesome test. * acquisition file owners.
Co-authored-by: Herrera <eduardo.herrera@quartech.com>
* psp-7909 take ui refactor. * psp-8145 * correct invalid type. * code review corrections. * merge corrections.
* vitest fixes. * re-install moment-timezone. * vitest performance and mocking corrections. * ensure console warnings are treated as failures. * try skipping troublesome test. * update msw, make some corrections to aid with test instability. * increase maxworkers now that test stability increased. * package updates.
* Code cleanup * Show common area component on lease view * Update property-lease repository to return area unit type-code * Use common area component to update lease property areas * Test updates * Increase spacing as per UI/UX review * Update snapshots
…gov#3986) Co-authored-by: Alejandro Sanchez <emailforasr@gmail.com>
…gov#3991) * PSP-8366 : Enforce character limit on file names in document list * - updates --------- Co-authored-by: Herrera <eduardo.herrera@quartech.com>
Co-authored-by: Herrera <eduardo.herrera@quartech.com>
* IS-79.00 Property View Updates * IS-79.00 Added PIMS_PROPERTY_VW View --------- Co-authored-by: Manuel Rodriguez <marobej@gmail.com>
Correctly handle either comma or pipe delimeted pids. Add error message for multiple pid responses.
…ated (bcgov#4002) * Updated take calculation to use incoming take if being updated * PR fixes
PIMS Property and Address Merge ETL
✅ No secrets were detected in the code. |
devinleighsmith
approved these changes
May 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## test #4005 +/- ##
===========================================
+ Coverage 74.65% 85.37% +10.71%
===========================================
Files 1443 1585 +142
Lines 40088 119668 +79580
Branches 8244 9181 +937
===========================================
+ Hits 29929 102161 +72232
- Misses 9860 17205 +7345
- Partials 299 302 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.